New issue
Advanced search Search tips

Issue 664286 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools Profiler: wrong URL for native V8 functions

Project Member Reported by caseq@google.com, Nov 10 2016

Issue description

0. Navigate to http://theverge.com
1. Open DevTools, switch to Timeline
2. Reload
3. Switch to "Bottom-up Tree" in Timeline drawer
4. Select grouping by URL in the combobox 
5. Scroll down a bit -- observe that while most URLs are plausible, some URLs are like String, Number, getTime, charAt and other names of native JS functions.
 

Comment 1 by alph@chromium.org, Dec 7 2016

Labels: Hotlist-Polish
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0f39ef5fdfef3a8d68a05057d2896c52882582a1

commit 0f39ef5fdfef3a8d68a05057d2896c52882582a1
Author: alph <alph@chromium.org>
Date: Wed Dec 21 07:52:05 2016

[profiler] Do not report native function names as script names.

BUG= chromium:664286 

Review-Url: https://codereview.chromium.org/2595673002
Cr-Commit-Position: refs/heads/master@{#41884}

[modify] https://crrev.com/0f39ef5fdfef3a8d68a05057d2896c52882582a1/src/code-events.h
[modify] https://crrev.com/0f39ef5fdfef3a8d68a05057d2896c52882582a1/src/log.cc

Comment 3 by alph@chromium.org, Jan 5 2017

Status: Fixed (was: Assigned)

Sign in to add a comment