New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664269 link

Starred by 1 user
Status: Fixed
Owner:
█ bshe@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Cleanup reflections in vr_shell folder

Project Member Reported by bshe@chromium.org, Nov 10 2016 
Reflections are needed before we ship webvr/ChromeVR feature. These features are hided behind a build time flag which java can't use, hence reflection. We should clean up these once WebVr shipped.

Comment 1 by bshe@chromium.org, Nov 11 2016 

Note if mipsel also compiles the java code that use reflection, we will need to keep these reflection. But refactor them to a builder class so that only one reflection is needed.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83

commit e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83
Author: bshe <bshe@chromium.org>
Date: Tue Nov 29 00:46:16 2016

Use VrClassesBuilder to reduce reflection usage

BUG= 664269 

Review-Url: https://codereview.chromium.org/2530923002
Cr-Commit-Position: refs/heads/master@{#434801}

[modify] https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java
[add] https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilder.java
[add] https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java
[modify] https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java
[modify] https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
[modify] https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/e7b460b60c8e8cf9486e6699bdc2a3b4bc55be83/chrome/android/java_sources.gni

Comment 3 by ddorwin@chromium.org, Nov 30 2016

Labels: Proj-VR-Daydream

Comment 4 by bshe@chromium.org, Dec 1 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment