IME for Mus: Make sure IMEServerImpl connects to the driver it intends to. |
|||||
Issue descriptionAny IME driver can register itself to Mus. IMEServerImpl requests an specific IME driver to register itself. IMEServerImpl should make sure that the driver registering itself is the same that it requested for.
,
Dec 9 2016
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1340ff2da37b5fcd669e08842cea9223b325a873 commit 1340ff2da37b5fcd669e08842cea9223b325a873 Author: sky <sky@chromium.org> Date: Fri Jan 20 21:30:53 2017 mash: Makes mash and service:ui not establish outgoing connections The ui service was connecting to chrome for the ime driver. As the ui service is a singleton and chrome isn't, this triggered launching another process of chrome, which we don't want. Turns out having ui connect to chrome for the ime driver is unnecessary as chrome already does this. So, removing the code. Mash was connecting to the chrome for the keyboard service. This is also problematic for similar reasons, so removing it too. Filed bug to have chrome register keyboard with mash. BUG= 664267 , 662157 , 664264 , 683192 , 683289 TEST=none R=moshayedi@chromium.org Review-Url: https://codereview.chromium.org/2645683007 Cr-Commit-Position: refs/heads/master@{#445172} [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/ash/mus/BUILD.gn [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/ash/mus/keyboard_ui_mus.cc [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/BUILD.gn [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/ime_server_impl.cc [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/ime_server_impl.h [modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/manifest.json
,
Jan 23 2017
,
Feb 26 2018
,
Feb 26 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by moshayedi@chromium.org
, Dec 8 2016