New issue
Advanced search Search tips

Issue 664261 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

FocusManagerTest.WidgetFocusChangeListener fails with aura-mus-client

Project Member Reported by sky@chromium.org, Nov 10 2016

Issue description

This test calls Focus() directly on the aura::Window associated with a widget and expects it to trigger activation changes. That isn't wired up correctly and so the test fails.

I'm making the test early out for the time being.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a178499ab5e3a157c30198dc94deed31104360d9

commit a178499ab5e3a157c30198dc94deed31104360d9
Author: sky <sky@chromium.org>
Date: Fri Nov 11 05:34:32 2016

Changes views_aura_mus_unittests to create DesktopNativeWidgetAura

And disables a bunch of tests that are either broke or don't make
sense.

Tests that don't call CreatePlatformNativeWidgetImpl() already
create a DesktopNativeWidgetAura, but those calling
CreatePlatformNativeWidgetImpl() ended up with a
NativeWidgetAura. This patch makes it so when aura-mus-client is used
CreatePlatformNativeWidgetImpl() creates a DesktopNativeWidgetAura
(assuming that is appropriate).

Additionally I'm making ViewsTestBase::GetContext() return null for
aura-mus-client. That way we sure see failures early on.

BUG= 663903  663809 663561  663868   664261   664280   615033 
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2488393003
Cr-Commit-Position: refs/heads/master@{#431505}

[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/BUILD.gn
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/accessible_pane_view_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/controls/button/menu_button_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/controls/native/native_view_host_aura_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/event_monitor_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/focus/focus_manager_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/mus/mus_client.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/mus/mus_client.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/mus/views_aura_mus_test_suite.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/mus/views_mus_test_suite.cc
[delete] https://crrev.com/93f33fbe1479699499e6e05793785a02fdb1cc81/ui/views/test/native_widget_factory.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/native_widget_factory.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/native_widget_factory_aura_mus.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/native_widget_factory_desktop.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/native_widget_factory_mus.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/platform_test_helper.h
[add] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/platform_test_helper_cocoa.mm
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/scoped_views_test_helper.h
[add] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/test_platform_native_widget.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/test_views.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/views_test_base.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/views_test_base.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/views_test_helper_aura.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/widget_test.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/widget_test_aura.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/widget_test_mac.mm
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/touchui/touch_selection_controller_impl_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/touchui/touch_selection_menu_runner_views_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/view_unittest_aura.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/native_widget_mac_unittest.mm
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/native_widget_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/widget_unittest.cc

Comment 2 by sky@chromium.org, Mar 7 2017

Owner: e...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by e...@chromium.org, Mar 6 2018

Owner: ----
Status: Available (was: Assigned)
Mass unassigning bugs
Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Labels: -Pri-3 Pri-2
Owner: sky@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e4bcadfe0c50819e48607fbf54a35eeb7b2f4d9

commit 3e4bcadfe0c50819e48607fbf54a35eeb7b2f4d9
Author: Scott Violet <sky@chromium.org>
Date: Fri Sep 07 18:43:29 2018

views: enable FocusManagerTest.WidgetFocusChangeListener for mus

It no longer fails.

BUG= 664261 
TEST=test only change

Change-Id: Id17c9b0950fd20e001b27f104912542daaf8bc8b
Reviewed-on: https://chromium-review.googlesource.com/1213931
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589603}
[modify] https://crrev.com/3e4bcadfe0c50819e48607fbf54a35eeb7b2f4d9/ui/views/focus/focus_manager_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment