New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664248 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 604105
issue 436283



Sign in to add a comment

WebBluetooth chooser improvements

Project Member Reported by juncai@chromium.org, Nov 10 2016

Issue description

1. change the "pair with:" to "pair"
   change the "connect to:" to "connect"
2. Change the footnote view background color to grey on Mac to match that on non-Mac desktops. 

 

Comment 1 by juncai@chromium.org, Nov 10 2016

Uploaded some screenshots.
WebBluetooth_chooser_Mac.png
116 KB View Download

Comment 2 Deleted

Comment 3 by rolfe@chromium.org, Nov 11 2016

That string reads weird to me but if it's the UI Review preference I understand.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fc545ee6c46229dbe74c5f0cb406fd938ed4737

commit 5fc545ee6c46229dbe74c5f0cb406fd938ed4737
Author: juncai <juncai@chromium.org>
Date: Fri Nov 11 01:52:20 2016

Modify WebBluetooth chooser based on UI review feedback

This CL modifies the WebBluetooth chooser in the following:
1. change the "pair with:" to "pair"
   change the "connect to:" to "connect"
2. Change the footnote view background color to grey on Mac to match that
on non-Mac desktops.

I uploaded a screenshot on the issue page.

BUG= 664248 

Review-Url: https://codereview.chromium.org/2488383002
Cr-Commit-Position: refs/heads/master@{#431452}

[modify] https://crrev.com/5fc545ee6c46229dbe74c5f0cb406fd938ed4737/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/5fc545ee6c46229dbe74c5f0cb406fd938ed4737/chrome/app/generated_resources.grd
[modify] https://crrev.com/5fc545ee6c46229dbe74c5f0cb406fd938ed4737/chrome/browser/ui/cocoa/chooser_content_view_cocoa.h
[modify] https://crrev.com/5fc545ee6c46229dbe74c5f0cb406fd938ed4737/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm

Comment 5 by juncai@chromium.org, Nov 11 2016

Status: Fixed (was: Started)

Sign in to add a comment