New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664240 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Centering "Turn on Bluetooth to allow pairing" vertically & horizontally on the chooser

Project Member Reported by juncai@chromium.org, Nov 10 2016

Issue description

Currently the message "Turn on Bluetooth to allow pairing" is aligned left on the chooser. It would be better to move it in the center of the chooser both vertically and horizontally. We plan to fix it for M57.
 
Status: Started (was: Assigned)

Comment 2 by juncai@chromium.org, Jan 10 2017

Here are the screenshots from ChromeOS, Mac, and Android by centering "Turn on Bluetooth to allow pairing" on the chooser.
chooser_ChromeOS.png
54.1 KB View Download
chooser_Mac.png
91.8 KB View Download
chooser_Android.png
147 KB View Download

Comment 3 by rolfe@chromium.org, Jan 11 2017

Cc: -ainslie@chromium.org hannahs@chromium.org
(removing ainslie@, adding hannahs@)

Thanks for the screengrabs. The desktop ones look OK but curious for hannahs' thoughts on the Android one. ainslie@ had wanted better alignment on desktop (https://docs.google.com/presentation/d/1MkQdLUu3rJe23qhS_XbNEO8aM7YX1IR98N89yj9z7Uc/edit#slide=id.g18618d0a16_2_16) but I'm thinking maybe the Android message should stay top-aligned. What do you think, hannahs@?

(I also wouldn't be surprised if the message changes back to top-left-aligned on desktop post-Harmony, but we can just keep an eye on that. It does look better centered within the box.)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fa22cff92afbaa7bf994ea2a950c306f92e0749

commit 2fa22cff92afbaa7bf994ea2a950c306f92e0749
Author: juncai <juncai@chromium.org>
Date: Wed Jan 11 22:23:12 2017

Centering turn on Bluetooth message on the chooser

Currently the message "Turn on Bluetooth to allow pairing" is aligned
left on the chooser. This CL moves it to the center of the chooser.

I uploaded some screenshots on the issue page.

BUG= 664240 

Review-Url: https://codereview.chromium.org/2627483003
Cr-Commit-Position: refs/heads/master@{#443015}

[modify] https://crrev.com/2fa22cff92afbaa7bf994ea2a950c306f92e0749/chrome/android/java/res/layout/item_chooser_dialog.xml
[modify] https://crrev.com/2fa22cff92afbaa7bf994ea2a950c306f92e0749/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm
[modify] https://crrev.com/2fa22cff92afbaa7bf994ea2a950c306f92e0749/chrome/browser/ui/views/device_chooser_content_view.cc

From what I understand from comment #3, desktop changes were approved but NOT necessarily mobile ones. I personally think the Android message should stay top-aligned FWIW.

Comment 6 by juncai@chromium.org, Jan 12 2017

Sorry, should've waited for a while to land that patch.

Here are some more information, I uploaded some screenshots at:
https://bugs.chromium.org/p/chromium/issues/detail?id=676639
which shows the "Turn on Bluetooth to allow pairing" message on the center of the chooser. Since in that CL, the string has been modified from "Turn on Bluetooth in device settings to allow pairing" to "Turn on Bluetooth to allow pairing" to match the string that is used on desktops. This maybe makes the string appearing in the center look better. What do you think?
It does look nicer since it is shorter. I wonder how that will look like in non-english and more verbose languages like French though.

Comment 8 by rolfe@chromium.org, Jan 13 2017

I honestly don't know our policy on centering/alignment in dialogs. Generally everything is top-left aligned but that doesn't mean it has to stay that way.

hannahs@ - do you prefer the top-left aligned string here (https://docs.google.com/presentation/d/1MkQdLUu3rJe23qhS_XbNEO8aM7YX1IR98N89yj9z7Uc/edit#slide=id.g18618d0a16_2_16) or the vertically centered one here (https://bugs.chromium.org/p/chromium/issues/detail?id=676639#c14)? Do we have a standard about when to center text on Chrome (desktop and/or mobile?)

Comment 9 by juncai@chromium.org, Feb 13 2017

Can we mark this issue as fixed?

Comment 10 by rolfe@chromium.org, Feb 13 2017

hannahs - waiting your feedback in Comment 8
ping, :).
My apologies for the delay in response! I had some issues with my inbox filters so this missed my radar :(

I think we should be consistent with the how Connection info, and Page info are presented (left aligned). Also, once the user turns on bluetooth, the device list and "Not seeing your device" strings are left aligned so let's keep it left.

Having said that, the spacing currently is a bit awkward, so let's change the type treatments / spacing so that it's consistent with state when bluetooth is on (see attached redlines).

Please feel free to ping me with any questions / concerns!
02.png
60.1 KB View Download
redlines.png
157 KB View Download
OK, so for the desktops, the message can stay on the center as it does now, for Andorid, the message needs to be moved to the top-left as it was before, right?
Cc: hwi@chromium.org bettes@chromium.org
CC'ing the desktop UX designers

Comment 15 by hwi@chromium.org, Mar 9 2017

re: c13 - for desktops, yes the center alignment as-is looks good. Confirmed with bettes@. Thanks!
Thanks! I will submit a CL that moves the message to the top-left of the chooser on Android.
Here is the screenshot.
chooser_android.png
93.9 KB View Download
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51428a67c2be408c20522f9c35be693fe84e6a98

commit 51428a67c2be408c20522f9c35be693fe84e6a98
Author: juncai <juncai@chromium.org>
Date: Fri Mar 10 18:18:12 2017

Move "Turn on Bluetooth to allow pairing" to top-left on chooser on Android

This CL is a follow-up for:
https://codereview.chromium.org/2627483003

After discussion with UI team, the text message on the chooser should
stay on the top-left as it was before the above CL. So this CL changes
it back.

BUG= 664240 

Review-Url: https://codereview.chromium.org/2744713003
Cr-Commit-Position: refs/heads/master@{#456111}

[modify] https://crrev.com/51428a67c2be408c20522f9c35be693fe84e6a98/chrome/android/java/res/layout/item_chooser_dialog.xml

Status: Fixed (was: Started)

Sign in to add a comment