New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664239 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojo buffers should not be limited to 16MB

Project Member Reported by jcivelli@chromium.org, Nov 10 2016 
The Mojo buffers (shared memory) are now limited to 16MB in size.
This is causing problems are we are migrating the current Chrome IPC messages to mojo and are starting to use Mojo buffers instead of SharedMemory directly passed in IPC messages.

We should make the Mojo buffers have the same allocation limit as SharedMemory.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f093c54710346e88480688d71b1116be793919ff

commit f093c54710346e88480688d71b1116be793919ff
Author: jcivelli <jcivelli@chromium.org>
Date: Fri Nov 11 17:52:11 2016

Removing the Mojo buffers 16MB size limit.
It is causing problems as we are migrating the current Chrome IPC messages
to mojo and are starting to use Mojo buffers to replace the existing
SharedMemory instances directly passed in IPC messages.
Since Mojo buffer use SharedMemory, get rid of the check at the mojo level
and rely on SharedMemory limit.

BUG= 664239 

Review-Url: https://codereview.chromium.org/2488253003
Cr-Commit-Position: refs/heads/master@{#431590}

[modify] https://crrev.com/f093c54710346e88480688d71b1116be793919ff/mojo/edk/system/broker_host.cc

Comment 2 by jcivelli@chromium.org, Nov 11 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment