New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664236 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Nov 2016
Cc:
█ yzshen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

mojo_public_bindings_unittests InvalidMessageDuringSyncCall is crashy on android 5x swarming bots

Project Member Reported by boliu@chromium.org, Nov 10 2016 
Was looking at crbug.com/664211, but I was surprised to discover this test suite is flakily crashing, at least on that bot, but don't turn the bot green because crashes/failures are retried.

A few examples:
https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/6191
I   22.392s run_tests_on_device(00ba31c98f874621)  [ RUN      ] SyncMethodCommonTest/1.InvalidMessageDuringSyncCall
I   22.392s run_tests_on_device(00ba31c98f874621)  [ERROR:validation_errors.cc(87)] Invalid message: VALIDATION_ERROR_ILLEGAL_MEMORY_RANGE
I   22.393s run_tests_on_device(00ba31c98f874621)  [ CRASHED      ]


Unfortunately android bot doesn't provide much more info like giving a crash stack. But given this is a unit test, someone probably should take a look?

Comment 1 by yzshen@chromium.org, Nov 10 2016

Cc: roc...@chromium.org yzshen@chromium.org
Hi, Ken.

This test intentionally dispatches an invalid message. Is it possible that our bad message handling logic tries to kill the process because of that, and depending on whether that happens before test completion the test is flakily crashing?

Comment 2 by roc...@chromium.org, Nov 10 2016

Cc: -roc...@chromium.org
Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
I'll take a look
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d4a788a20e336d82ba48f9918d0d09ebd17a787

commit 9d4a788a20e336d82ba48f9918d0d09ebd17a787
Author: rockot <rockot@chromium.org>
Date: Fri Nov 11 00:34:49 2016

Mojo Bindings: Reset EDK error callback in ReportBadMessageTest::TearDown

We were leaving a stale callback bound here which can cause other tests
(namely things which explicitly test invalid message behavior) to UAF
on the bound state.

BUG= 664236 
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2490403002
Cr-Commit-Position: refs/heads/master@{#431413}

[modify] https://crrev.com/9d4a788a20e336d82ba48f9918d0d09ebd17a787/mojo/public/cpp/bindings/tests/report_bad_message_unittest.cc

Comment 4 by roc...@chromium.org, Nov 11 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment