New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664233 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 652767
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 645188



Sign in to add a comment

Need nechanism to associate navigation handles with MAIN_FRAME URLRequests with PlzNavigate

Project Member Reported by kundaji@chromium.org, Nov 10 2016

Issue description

GlobalRequestIDs are curently being used to associate navigation handles with MAIN_FRAME URLRequests. However, GlobalRequestID is not being populated in PlzNavigate use case.

When --enable-browser-side-navigation is true, either GlobalRequestID must be populated or an alternate mechanism be used to associate navigation handles with MAIN_FRAME URLRequests.
 
On thinking about this some more, populating GlobalRequestID is the best way to do this.

This entails propagating the GlobalRequestID all the way to WillProcessResponse(NavigationURLLoaderImplCore::NotifyResponseStarted, NavigationURLLoaderImpl::NotifyResponseStarted, etc).
Labels: -Pri-2 Pri-1
Mergedinto: 652767
Status: Duplicate (was: Assigned)

Comment 4 by jam@chromium.org, Mar 18 2017

Status: Assigned (was: Duplicate)
The duped bug is for a feature request in core PlzNavigate code. But this feature is still not implemented, judging by the TODOs and early exits: https://cs.chromium.org/chromium/src/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc?type=cs&q=%22//+TODO(ryansturm):+Handle+PlzNavigate+(http://crbug/664233).%22&l=57
Labels: -Pri-1 Pri-2
I believe that https://codereview.chromium.org/2537593002 plumbed the actual GlobalRequestID for plzNavigate, so I will investigate and fix the TODOs in ChromeDataUseAscriber code.

Comment 6 by bengr@chromium.org, May 4 2017

What's the status of this?
Owner: rajendrant@chromium.org
Raj is looking at this.

Comment 8 by nasko@chromium.org, May 4 2017

Cc: clamy@chromium.org nasko@chromium.org
Labels: M-60 Proj-PlzNavigate
Adding Proj-PlzNavigate, which we are aiming to launch in M60.
Ascribing URLRequest to RenderFrameHost should happen based on GlobalRequestID. ResourceRequestInfo::GetRenderFrameForRequest() should not be used in GetOrCreateDataUseRecorderEntry().
To be clear, mainframe and subframe navigations will only have GlobalRequestID populated in the request when it starts (RenderFrameHost ID will not be populated). This is true for PlzNavigate and non PlzNavigate cases.

For subresource requests RenderFrameHost ID should be populated, and ascription should use that.
Project Member

Comment 11 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/975ba1a456087d8781f61754b747c66dab30c97f

commit 975ba1a456087d8781f61754b747c66dab30c97f
Author: tbansal <tbansal@chromium.org>
Date: Wed May 31 20:40:30 2017

PlzNavigate support in data use ascriber

With PlzNavigate, RenderFrameHost will not be populated in mainframe
requests. So global request ID alone should be used for mapping those
requests to main renderframe, when navigation commits later. This CL is
based off of Chromium CL 2874353002.

BUG= 664233 
TBR=rajendrant@chromium.org

Review-Url: https://codereview.chromium.org/2913063002
Cr-Commit-Position: refs/heads/master@{#476006}

[modify] https://crrev.com/975ba1a456087d8781f61754b747c66dab30c97f/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/975ba1a456087d8781f61754b747c66dab30c97f/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
[modify] https://crrev.com/975ba1a456087d8781f61754b747c66dab30c97f/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/975ba1a456087d8781f61754b747c66dab30c97f/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc

Cc: rajendrant@chromium.org
Owner: tbansal@chromium.org
Cc: ryansturm@chromium.org
Labels: -M-60 M-61
Status: Fixed (was: Assigned)
This is fixed. https://codereview.chromium.org/2914923002/ should also have pointed to this bug.

Sign in to add a comment