New issue
Advanced search Search tips

Issue 664231 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 652403



Sign in to add a comment

Add Internals::setMarker(range, markerType) to make layout test easier

Project Member Reported by chaopeng@chromium.org, Nov 10 2016

Issue description

Add Internals::setMarker(range, markerType) to make layout test easier.

Also move other internals change from https://codereview.chromium.org/2457523003 to the issue. includes:

add replaceMisspelled
add exception in spell-check related

https://codereview.chromium.org/2457523003/#msg32

 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af7933e7d353a66f958961bc8f1b2f398378d84c

commit af7933e7d353a66f958961bc8f1b2f398378d84c
Author: chaopeng <chaopeng@chromium.org>
Date: Tue Nov 15 06:00:13 2016

Introduce Internals#replaceMisspelled() and Internals#setMarker()

This patch introduce setMarker for ease of writing test case with document markers
and replaceMisspelled for replace misspelled.

This patch is a preparation of http://crrev.com/2457523003 which uses
Internals#replaceMisspelled() and Internals#setMarker()

BUG= 664231 
TEST=n/a; no behavior changes.

Review-Url: https://codereview.chromium.org/2493873002
Cr-Commit-Position: refs/heads/master@{#432123}

[add] https://crrev.com/af7933e7d353a66f958961bc8f1b2f398378d84c/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-marker.html
[modify] https://crrev.com/af7933e7d353a66f958961bc8f1b2f398378d84c/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/af7933e7d353a66f958961bc8f1b2f398378d84c/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/af7933e7d353a66f958961bc8f1b2f398378d84c/third_party/WebKit/Source/core/testing/Internals.idl

Status: Fixed (was: Started)

Sign in to add a comment