New issue
Advanced search Search tips

Issue 664215 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.9%-15.8% regression in storage.indexeddb_endure_tracing at 429986:430312

Project Member Reported by dmu...@chromium.org, Nov 10 2016

Issue description

Regression in commit and put time for idb
 

Comment 3 by dmu...@chromium.org, Nov 10 2016

Cc: cmumford@chromium.org

Comment 4 by rbyers@chromium.org, Nov 18 2016

Labels: Performance
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Apr 10 2017

Cc: reillyg@chromium.org
Owner: reillyg@chromium.org

=== Auto-CCing suspected CL author reillyg@chromium.org ===

Hi reillyg@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : reillyg
  Commit : 963ec6df64089bef6867ccdc608101d5fc06d5c0
  Date   : Sat Nov 05 01:13:13 2016
  Subject: Port messages sent by WebIDBDatabaseImpl to Mojo.

Bisect Details
  Configuration: mac_10_10_perf_bisect
  Benchmark    : storage.indexeddb_endure_tracing
  Metric       : idb-transaction-commits/Action_Test/indexeddb-endure-testCreateAndDeleteDatabases

Revision             Result                   N
chromium@430109      0.947077 +- 4.65529      300      good
chromium@430110      1.08279 +- 7.18457       300      bad       <--
chromium@430111      1.10469 +- 7.00778       300      bad
chromium@430113      1.07107 +- 6.69795       300      bad
chromium@430117      1.07202 +- 6.5363        300      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests storage.indexeddb_endure_tracing

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982667490496586672

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4961078511927296


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 7 by dmu...@chromium.org, Apr 11 2017

so for more info, this is timing IndexedDBTransaction::Commit (https://cs.chromium.org/chromium/src/content/browser/indexed_db/indexed_db_transaction.cc?q=IndexedDBTransaction::Commit&l=288)

I'm not super sure what this means
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Apr 11 2017


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : reillyg
  Commit : 963ec6df64089bef6867ccdc608101d5fc06d5c0
  Date   : Sat Nov 05 01:13:13 2016
  Subject: Port messages sent by WebIDBDatabaseImpl to Mojo.

Bisect Details
  Configuration: mac_retina_perf_bisect
  Benchmark    : storage.indexeddb_endure_tracing
  Metric       : idb-transaction-commits/Action_Test/indexeddb-endure-testReadCacheWithoutIndex
  Change       : 12.87% | 1.35268489583 -> 1.526796875

Revision             Result                    N
chromium@430101      1.35268 +- 0.0545537      6      good
chromium@430108      1.34124 +- 0.048308       6      good
chromium@430109      1.36402 +- 0.0756975      6      good
chromium@430110      1.49133 +- 0.0695484      6      bad       <--
chromium@430111      1.49579 +- 0.0756237      6      bad
chromium@430114      1.50219 +- 0.128306       6      bad
chromium@430127      1.48989 +- 0.0964802      6      bad
chromium@430152      1.5268 +- 0.0886828       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=indexeddb.endure.testReadCacheWithoutIndex storage.indexeddb_endure_tracing

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982576486428779568

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4961078511927296


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Since there is an owner, this bug is not untriaged. Updating the status.
Owner: ----
Status: Untriaged (was: Assigned)
Removing myself as owner. dmurph@, please triage if this is an issue we can/should fix.
Labels: -Performance Performance-Memory Performance-Sheriff
Status: WontFix (was: Untriaged)
Hm.. this is commit time. Interesting. We can't revert the change, it's part of the new architecture, so I'm going to label this as wontfix. I have no idea why this changed cause this behavior though, it didn't change indexeddb internals too much.

Sign in to add a comment