New issue
Advanced search Search tips

Issue 664206 link

Starred by 1 user
Status: WontFix
Owner:
schenney@chromium.org
Closed: Dec 10
Cc:
szager@chromium.org
f...@opera.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LayoutSize for svg root is only updated in one dimension

Project Member Reported by ymalik@chromium.org, Nov 10 2016 
This was found in https://codereview.chromium.org/2454913003/.

The change above caused svg/custom/masking-clipping-hidpi.svg to fail because the Layout dimensions for the svg document were only updated in one dimension. 

See comments in Patch Set 9 for more details.

Comment 1 by e...@chromium.org, Sep 8 2017

Components: -Blink>Layout Blink>SVG
Status: Untriaged (was: Available)

Comment 2 by schenney@chromium.org, Sep 11 2017

Cc: f...@opera.com
Labels: BugSource-Chromium PaintTeamTriaged-20170911
Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)
This seems simple to fix.

Comment 3 by f...@opera.com, Feb 2 2018 

I guess this might be taking the IsDocumentElement() code-path [1] in LayoutSVGRoot::ComputeReplacedLogicalHeight, which resolves against LayoutView::ViewLogicalHeightForPercentages. So if the height isn't updated it essentially mean that the underlying height that it uses isn't updated either.

[1] ...which I'm not quite sure why it's there - if it wasn't I think we'd still resolve against the available height of the (I)CB - which is the visible height of the LayoutView (indirectly FrameView).

Comment 4 by f...@opera.com, Feb 2 2018

Cc: szager@chromium.org
Hmm, actually that case was added more recently than this bug was reported, by https://codereview.chromium.org/2835153002/, which looks like it may have fixed this bug (no bug ref though, +szager)

Comment 5 by f...@opera.com, Dec 10

Status: WontFix (was: Assigned)
Closing per c#4.
►

Sign in to add a comment