New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664192 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Nov 2016
Cc:
tommycli@chromium.org
█ justincarlson@chromium.org
alemate@chromium.org
█ dschuyler@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

CrSettingsMetricsReportingTest.All is failing in official builds

Project Member Reported by thakis@chromium.org, Nov 10 2016 
e.g. here: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/6635

CrSettingsMetricsReportingTest.All (run #1):
[ RUN      ] CrSettingsMetricsReportingTest.All
[2336:6468:1110/081202:INFO:CONSOLE(1209)] "Running TestCase CrSettingsMetricsReportingTest.All", source: test_api.js (1209)
[2336:6468:1110/081202:ERROR:CONSOLE(48)] "Mocha test failed: metrics reporting changes to whether metrics reporting is enabled/managed
AssertionError: expected false to be true
    at Function.assert.isTrue (chai.js:2423:31)
    at assertTrue (test_api.js:854:17)
    at metrics_reporting_tests.js:38:7
", source: mocha_adapter.js (48)
[2336:6468:1110/081202:INFO:CONSOLE(125)] "Page load time: 362 ms", source: polymer_browser_test_base.js (125)
[2336:6468:1110/081202:INFO:CONSOLE(127)] "Test run time: 103 ms", source: polymer_browser_test_base.js (127)
[2336:6468:1110/081202:INFO:CONSOLE(129)] "Total time: 465 ms", source: polymer_browser_test_base.js (129)
[2336:6468:1110/081202:ERROR:web_ui_test_handler.cc(76)] Test Errors: 1/1 tests had failed assertions.
[2336:6468:1110/081202:ERROR:web_ui_browser_test.cc(473)] CONDITION FAILURE: encountered javascript console error(s):
[2336:6468:1110/081202:ERROR:web_ui_browser_test.cc(475)] JS ERROR: '[2336:6468:1110/081202:ERROR:CONSOLE(48)] "Mocha test failed: metrics reporting changes to whether metrics reporting is enabled/managed
AssertionError: expected false to be true
    at Function.assert.isTrue (chai.js:2423:31)
    at assertTrue (test_api.js:854:17)
    at metrics_reporting_tests.js:38:7
", source: mocha_adapter.js (48)
'
[2336:6468:1110/081202:ERROR:web_ui_browser_test.cc(477)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/settings/cr_settings_browsertest-gen.cc(1264): error: Value of: RunJavascriptTestF( true, "CrSettingsMetricsReportingTest", "All")
  Actual: false
Expected: true
[  FAILED  ] CrSettingsMetricsReportingTest.All, where TypeParam =  and GetParam() =  (1118 ms)

The test was still passing on Nov 3 and failing on Nov 4.

Comment 1 by thakis@chromium.org, Nov 10 2016

Cc: alemate@chromium.org tommycli@chromium.org justincarlson@chromium.org dschuyler@chromium.org
Labels: -OS-Mac OS-All
Related-looking CLs in the regression range:
https://codereview.chromium.org/2480473002
https://codereview.chromium.org/2471223002
https://codereview.chromium.org/2480543002
https://codereview.chromium.org/2468063003


and maybe alemate's user email patch series (https://codereview.chromium.org/2471993002 etc)

Comment 2 by dbeam@chromium.org, Nov 10 2016

Cc: -dbeam@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Untriaged)

Comment 3 by dpa...@chromium.org, Nov 10 2016

Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c353bc35ec243f7a62600f92a184c58dba6df75

commit 2c353bc35ec243f7a62600f92a184c58dba6df75
Author: dbeam <dbeam@chromium.org>
Date: Fri Nov 11 03:45:07 2016

MD Settings: slight tweaks to when the metrics reporting restart button shows up

Should also hopefully fix the tests on official builders.

R=dpapad@chromium.org
BUG= 664192 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2494813002
Cr-Commit-Position: refs/heads/master@{#431486}

[modify] https://crrev.com/2c353bc35ec243f7a62600f92a184c58dba6df75/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/2c353bc35ec243f7a62600f92a184c58dba6df75/chrome/test/data/webui/settings/metrics_reporting_tests.js
►

Sign in to add a comment