New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664184 link

Starred by 1 user
Status: Duplicate
Merged: issue 664176
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

org.chromium.net.SdchTest#testSdchEnabled is flaky

Project Member Reported by tobiasjs@chromium.org, Nov 10 2016 
cronet_test_instrumentation_apk failing on chromium.android/Android Cronet Lollipop Builder

Type: build-failure

Builders failed on: 
- Android Cronet Lollipop Builder: 
  https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder

The test appears to be racy.

Because SdchObserver registers the native observer in its constructor, it's possible that in DictionaryAddedObserver, mBlock hasn't been initialized at the time that onDictionaryAdded is called.

Comment 1 by tobiasjs@chromium.org, Nov 10 2016 

Relevant log snippet:

4b057:  11-10 15:07:43.507 13999 14017 I TestRunner: started: testSdchEnabled(org.chromium.net.SdchTest)
4b057:  11-10 15:07:43.514 13999 14017 I cr_CronetTestFramework: Cronet commandLine cache = disk
4b057:  11-10 15:07:43.514 13999 14017 I cr_CronetTestFramework: Cronet commandLine sdch = enable
4b057:  11-10 15:07:43.514 13999 14017 I cr_CronetTestFramework: Cronet commandLine libraryInit = cronet
4b057:  11-10 15:07:43.516 13999 14017 W linker  : libcronet_tests.so: unused DT entry: type 0x6ffffffe arg 0x2f94
4b057:  11-10 15:07:43.516 13999 14017 W linker  : libcronet_tests.so: unused DT entry: type 0x6fffffff arg 0x3
4b057:  11-10 15:07:43.524 13999 14017 I cr_CronetLibraryLoader: Cronet version: 56.0.2916.0, arch: armv7l
4b057:  11-10 15:07:43.530 13999 14017 I CronetEngineBuilder: dalvik.system.PathClassLoader[DexPathList[[zip file "/system/framework/android.test.runner.jar", zip file "/data/app/org.chromium.net.tests-1/base.apk", zip file "/data/app/org.chromium.net-1/base.apk"],nativeLibraryDirectories=[/data/app/org.chromium.net-1/lib/arm, /vendor/lib, /system/lib]]] found Cronet engine implementation class org.chromium.net.impl.CronetUrlRequestContext. Network stack version Cronet/56.0.2916.0@f023cccd
4b057:  11-10 15:07:43.534   792   809 D ConnectivityService: listenForNetwork for NetworkRequest [ id=66, legacyType=-1, [ Capabilities: INTERNET&NOT_RESTRICTED&TRUSTED] ]
4b057:  11-10 15:07:43.575 13999 14017 I CronetEngineBuilder: dalvik.system.PathClassLoader[DexPathList[[zip file "/system/framework/android.test.runner.jar", zip file "/data/app/org.chromium.net.tests-1/base.apk", zip file "/data/app/org.chromium.net-1/base.apk"],nativeLibraryDirectories=[/data/app/org.chromium.net-1/lib/arm, /vendor/lib, /system/lib]]] found Cronet engine implementation class org.chromium.net.impl.CronetUrlRequestContext. Network stack version Cronet/56.0.2916.0@f023cccd
4b057:  11-10 15:07:43.579 13999 14030 W System.err: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.os.ConditionVariable.open()' on a null object reference
4b057:  11-10 15:07:43.579 13999 14030 W System.err: 	at org.chromium.net.SdchTest$DictionaryAddedObserver.onDictionaryAdded(SdchTest.java:158)
4b057:  11-10 15:07:43.588 13999 14030 F chromium: [1110/150743:FATAL:jni_android.cc(243)] Please include Java exception stack in crash report

Comment 2 by xunji...@chromium.org, Nov 10 2016

Mergedinto: 664176
Status: Duplicate (was: Available)
Thanks tobiasjs@. I have a proposed fix in review.
►

Sign in to add a comment