New issue
Advanced search Search tips

Issue 664173 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 392575



Sign in to add a comment

Alt-Svc is not used if it contains IPv6 address

Reported by ok...@akamai.com, Nov 10 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36

Steps to reproduce the problem:
1. Visit webpage, where it's server is sending Alt-Svc header like
Alt-Svc: quic="[2003:8:0:16::509d:9615]:443"; v="36,35,34,33,32,31"; ma=60
2. Refresh the page
3. Check via chrome://net-internals/#alt-svc that you don't see record for that domain.

What is the expected behavior?
Chrome should parse that IPv6 address and store it in Alt-Svc cache. Then it should be used in subsequent requests to connect to that IP using QUIC.

What went wrong?
From my undestanding host part of Alt-Svc should comply with RFC3986:
https://tools.ietf.org/html/rfc3986#section-3.2.2
host        = IP-literal / IPv4address / reg-name
IP-literal = "[" ( IPv6address / IPvFuture  ) "]"
IPvFuture  = "v" 1*HEXDIG "." 1*( unreserved / sub-delims / ":" )

But in code it stops parsing of host when it sees first ocurence of ":"
https://cs.chromium.org/chromium/src/net/spdy/spdy_alt_svc_wire_format.cc?sq=package:chromium&dr=C&rcl=1478751499&l=306

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 54.0.2840.71  Channel: n/a
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0
 
Components: -Blink>Network Internals>Network>QUIC
This looks like a QUIC problem to me; presuming the QUIC folks can retarget if it's a more general HTTP/2 & QUIC problem.

Comment 2 by rch@chromium.org, Nov 10 2016

Components: -Internals>Network>QUIC Internals>Network>HTTP2
Owner: b...@chromium.org
Not a quic, problem just an Alt-Svc header parsing problem. Assigning to bnc.

Comment 3 by b...@chromium.org, Nov 10 2016

Status: Assigned (was: Unconfirmed)

Comment 4 by b...@chromium.org, Nov 11 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99fab9842b9ad3cee0f63008ae746f534dbac567

commit 99fab9842b9ad3cee0f63008ae746f534dbac567
Author: bnc <bnc@chromium.org>
Date: Mon Nov 14 23:50:30 2016

Allow IP literals in Alt-Svc hostnames.

This CL lands server change 139064393 by bnc.

BUG=488484,  664173 

Review-Url: https://codereview.chromium.org/2497223003
Cr-Commit-Position: refs/heads/master@{#431987}

[modify] https://crrev.com/99fab9842b9ad3cee0f63008ae746f534dbac567/net/spdy/spdy_alt_svc_wire_format.cc
[modify] https://crrev.com/99fab9842b9ad3cee0f63008ae746f534dbac567/net/spdy/spdy_alt_svc_wire_format_test.cc

Comment 6 by b...@chromium.org, Nov 15 2016

Status: Fixed (was: Started)

Comment 7 by b...@chromium.org, Feb 22 2017

Blocking: 392575

Comment 8 by b...@chromium.org, Feb 24 2017

Summary: Alt-Svc is not used if it contains IPv6 address (was: Alt-Svc is used if it contains IPv6 address)

Sign in to add a comment