New issue
Advanced search Search tips

Issue 664164 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
V1



Sign in to add a comment

authpolicy: Add unit tests to process_executor

Project Member Reported by ljusten@chromium.org, Nov 10 2016

Issue description

Add framework for unit testing in authpolicy.
Separate authpolicy.gyp into more modular targets.
Clean up process_executor.
 
Labels: M-56
Labels: -M-56 M-57
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c5b34804816dd2144e7469fca83c52d8f5dc7970

commit c5b34804816dd2144e7469fca83c52d8f5dc7970
Author: Lutz Justen <ljusten@chromium.org>
Date: Tue Nov 15 12:43:48 2016

Set up authpolicy ebuild for unit testing

Basic setup for unit tests in the authpolicy project, adds a
platform_pkg_test section.

BUG= chromium:664164 
TEST=Builds and runs unit tests

Change-Id: I32a094b1253e45b9e8bba0b30edece229c62d5b4
Reviewed-on: https://chromium-review.googlesource.com/411780
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/c5b34804816dd2144e7469fca83c52d8f5dc7970/chromeos-base/authpolicy/authpolicy-9999.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/875dd42a5e068859f89caf7c6c3b876e1c935f56

commit 875dd42a5e068859f89caf7c6c3b876e1c935f56
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Nov 10 15:02:00 2016

authpolicy: Add unit tests to process_executor

Sets up unit testing framework in authpolicy. Splits main
authpolicy build target into more modular intermediate targets.
Cleans up process_executor.

BUG= chromium:664164 
TEST=Ran unit tests on amd64-generic

Change-Id: I4b91239145c214d2ffa253bb29ef1088c8d4d092
Reviewed-on: https://chromium-review.googlesource.com/409970
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/875dd42a5e068859f89caf7c6c3b876e1c935f56/authpolicy/process_executor.cc
[modify] https://crrev.com/875dd42a5e068859f89caf7c6c3b876e1c935f56/authpolicy/process_executor.h
[add] https://crrev.com/875dd42a5e068859f89caf7c6c3b876e1c935f56/authpolicy/process_executor_unittest.cc
[modify] https://crrev.com/875dd42a5e068859f89caf7c6c3b876e1c935f56/authpolicy/authpolicy.gyp
[add] https://crrev.com/875dd42a5e068859f89caf7c6c3b876e1c935f56/authpolicy/authpolicy_testrunner.cc

Comment 6 by tnagel@chromium.org, Nov 21 2016

Labels: V1
Status: Fixed (was: Started)
Labels: Enterprise-Triaged
Status: Verified (was: Fixed)
bulk Verify of Chromad V1 bugs

Sign in to add a comment