New issue
Advanced search Search tips

Issue 664157 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Panning during a pinch gesture in PDF is jittery.

Project Member Reported by wjmaclean@chromium.org, Nov 10 2016

Issue description

Version: >= master@{#430973}
OS: all

What steps will reproduce the problem?
(1) Open a PDF in chrome using the built-in viewer.
(2) Initiate a pinch-zoom gesture.
(3) While still in the pinch-zoom gesture, pan/scroll left and right.

What is the expected result?

The PDF content should smoothly scroll left and right.

What happens instead?

The PDF content jumps around during the pan, though pure pinching appears to smoothly change scale.

Note that regular panning (i.e. 1-finger scroll), after the PZ gesture is complete, is smooth.

Please use labels and text to provide additional information.

 

Comment 1 by mcnee@chromium.org, Nov 10 2016

Owner: mcnee@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6e4fc5905ae3e09f54d0c7a2e0fb9d89badb435

commit a6e4fc5905ae3e09f54d0c7a2e0fb9d89badb435
Author: mcnee <mcnee@chromium.org>
Date: Tue Dec 06 18:00:21 2016

PDF pinch zoom: Update layer transform for a zoom out after a zoom in.

Currently, whenever we pinch zoom out, we clear any layer transform and
reraster at the new zoom level. However, during a pinch zoom in (and
especially when slowly panning), we may get occasional zoom out events
which cause us to clear the layer transform. As the zoom in continues
we will then set the layer transform again. This repeated setting and
clearing causes noticeable jumping back and forth of the PDF content.

In this patch, when we get a pinch zoom out, if a layer transform is
already set due to a previous zoom in, we update the layer transform
instead of clearing it.

BUG= 664157 

Review-Url: https://codereview.chromium.org/2541903002
Cr-Commit-Position: refs/heads/master@{#436640}

[modify] https://crrev.com/a6e4fc5905ae3e09f54d0c7a2e0fb9d89badb435/pdf/out_of_process_instance.cc

Comment 3 by mcnee@chromium.org, Dec 6 2016

Status: Fixed (was: Assigned)

Sign in to add a comment