New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664153 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

blink_style.top_25 failure on chromium.perf.fyi on Windows Low end laptops

Project Member Reported by eyaich@chromium.org, Nov 10 2016

Issue description

most recent failing builder: 
https://uberchromegw.corp.google.com/i/chromium.perf.fyi/builders/Win%2010%20Low-End%20Perf%20Tests/builds/1125

Link to swarming log: 

https://chromium-swarm.appspot.com/user/task/3266c95a99327110

Seems to be failing in blink_style.py (https://cs.chromium.org/chromium/src/tools/perf/measurements/blink_style.py?q=blink_style.py+file:%5Esrc/tools/perf/&sq=package:chromium&l=140) with a float division by zero.  This doesn't seem to be failing on any other windows bots so I am assuming it has something to do with these specific windows bots.  See relevant stack trace below.

Ben, Ethan, Ned, do you have any telemetry insight into what values it is trying to pull here to determine why they might be zero?  Seems like part of the trace event.  

INFO:root:PageCacheTemperature: any
INFO:root:Loading https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Faccounts.google.com%2FManageAccount...
INFO:root:Trace config file string: {"trace_config": {"included_categories": ["blink.console", "blink_style"], "record_mode": "record-as-much-as-possible"}}
INFO:root:Start Tracing Request: {'params': {'transferMode': 'ReturnAsStream', 'options': 'record-as-much-as-possible', 'categories': 'blink.console,blink_style'}, 'method': 'Tracing.start'}
INFO:root:Chrome version: 2623
INFO:root:Trace (TraceDataPart("telemetry")) of size 42904 bytes saved.
INFO:root:Trace (TraceDataPart("traceEvents")) of size 85324 bytes saved.
INFO:root:Trace (TraceDataPart("tabIds")) of size 40 bytes saved.
WARNING:root:No importer found for TraceDataPart("telemetry")
INFO:root:*************** BROWSER STANDARD OUTPUT ***************
INFO:root:
INFO:root:*********** END OF BROWSER STANDARD OUTPUT ************
INFO:root:********************* BROWSER LOG *********************
INFO:root:No log file
INFO:root:***************** END OF BROWSER LOG ******************
Traceback (most recent call last):
  File "c:\b\s\w\irqujagp\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 87, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "c:\b\s\w\irqujagp\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\irqujagp\third_party\catapult\telemetry\telemetry\page\shared_page_state.py", line 301, in RunStory
    self._current_page, self._current_tab, results)
  File "c:\b\s\w\irqujagp\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\irqujagp\tools\perf\measurements\blink_style.py", line 140, in ValidateAndMeasurePage
    'tokens/s', 1000 / (parse_duration / tokens)))
ZeroDivisionError: float division by zero
 

Comment 1 by zh...@chromium.org, Nov 15 2016

ping
Cc: dstockwell@chromium.org
+dstockwell in case he has any ideas about what might be happening here.

Similar to  crbug.com/664161 , I replied off-bug:

blink_style is sort of weird because it actually predates TBM and thus does a lot of stuff manually that we would normally automate using TimelineBasedMeasurement. My guess is that there's some timing assumption that has held true until now.
Cc: -nednguyen@chromium.org nedngu...@google.com
Ping. This should probably also get a new owner since she is out right now.
Status: Archived (was: Untriaged)
This benchmark has been deleted

Sign in to add a comment