New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664145 link

Starred by 2 users
Status: Fixed
Owner:
█ bshe@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Remove SDK dependency and use NDK once it is ready for VR_EXTRA string

Project Member Reported by bshe@chromium.org, Nov 10 2016 
Remove SDK dependency and use NDK once it is ready for VR_EXTRA string.
This should reduce our binary size.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c84c42ec3910d27eea80a9bef3db419339aff884

commit c84c42ec3910d27eea80a9bef3db419339aff884
Author: bshe <bshe@chromium.org>
Date: Fri Nov 11 20:45:36 2016

Remove gvr SDK dependency

SDK is used to only get a string which only avaialble in SDK. A bug has filed
to make the string available in NDK too. Before it fixed, we use a hard coded
string to remove the SDK dependency. This should reduce the binary size since
the proguard is configured to keep a lot of java functions.

BUG= 664145 

Review-Url: https://codereview.chromium.org/2490003003
Cr-Commit-Position: refs/heads/master@{#431633}

[modify] https://crrev.com/c84c42ec3910d27eea80a9bef3db419339aff884/chrome/android/BUILD.gn
[modify] https://crrev.com/c84c42ec3910d27eea80a9bef3db419339aff884/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/c84c42ec3910d27eea80a9bef3db419339aff884/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/c84c42ec3910d27eea80a9bef3db419339aff884/third_party/gvr-android-sdk/BUILD.gn

Comment 2 by ddorwin@chromium.org, Nov 30 2016

Labels: Proj-VR-Daydream

Comment 3 by ddorwin@chromium.org, Dec 8 2016

Labels: VR-TD

Comment 4 by bshe@chromium.org, Aug 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment