New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664126 link

Starred by 25 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Urgent Timezone Issue

Reported by mustafa...@gmail.com, Nov 10 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36

Steps to reproduce the problem:
1. 
2. 
3. 

What is the expected behavior?

What went wrong?
Hi Team,

I am a chrome user from Turkey. 
Turkey government decided not to change time due to daylight saving anymore. So on October 30th we were supposed to change time 1 hour back but we did not.
our new timezone is (UTC+03:00) Istanbul
Microsoft and oracle etc. released patches for this and we applied them all on our servers.
but unfortunately chrome does not show the correct time . 
for example when I visit an internet site and check chrome history, it shows the time of visit 1 hour earlier. the same problem exists when we open our applications via google chrome. Internet explorer work fine. Please do notice that this is an important problem for us. Please help as soon as possible.
The problem exists for all users in Turkey.

Did this work before? N/A 

Chrome version: 54.0.2840.99  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0
 
chrometimezoneproblem.jpg
216 KB View Download
Cc: ligim...@chromium.org
Components: UI>Browser>History
Labels: -Type-Bug -Pri-2 Proj-MaterialDesign-WebUI Pri-1 Type-Feature
I am tagging this bug as a feature request, I am not sure about the exact component which it belongs.
This is very important for us. Because of this bug we are not using Chrome for our applications and we started to use other web browsers. Our first choice is Chrome but can not use now because it is displaying the Elektronik Funds Transfers time wrong.
Regards,
Mustafa Çiçek

Status: Untriaged (was: Unconfirmed)
Issue seems more like a feature request and hence marking it as untriaged.

Thanks!
 Issue 664099  has been merged into this issue.
Cc: tsergeant@chromium.org
Labels: -Proj-MaterialDesign-WebUI -Type-Feature Type-Bug
Owner: js...@chromium.org
This is an issue with our core timezone library, not a high-level feature request.

Passing ownership to jshin@, who seems to be responsible for ICU data updates and might know more about this.
Components: -UI>Browser>History UI>Internationalization

Comment 7 by js...@chromium.org, Nov 16 2016

Labels: M-55
Status: Started (was: Untriaged)
It's a part of IETF timezone database 2016g. 

Chrome M56 has 2016h so that it's ok. Chrome M55 and M54 have 2016g so that they don't have this change. I missed 2016g.  


Let me update to 2016i (the latest) in M55 branch. 




Comment 8 by js...@chromium.org, Nov 16 2016

Labels: M-54
If there's gonna be one more release in M54, we need to update M54 as well. 

Comment 9 by js...@chromium.org, Nov 17 2016

Labels: Merge-Request-55
Status: Fixed (was: Started)
Fixed in M56 and trunk. 

Requesting for merge to M55:  https://codereview.chromium.org/2507323002
The change is very safe. It's just updating the IETF timezone database to 2016i (the latest) that includes a Turkey timezone change. 

I'll ask for M54 merge soon. 

Comment 10 by js...@chromium.org, Nov 17 2016

Labels: Merge-Request-54
Requesting for merge to M54: https://codereview.chromium.org/2507323002

Again, this is very safe (just updating the IETF timezone database to 2016i). Without this change, Turkey time is off by one hour. 


Comment 11 by js...@chromium.org, Nov 17 2016

Labels: -OS-Windows OS-All

Comment 12 by dimu@chromium.org, Nov 18 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M54), manual review required.

Comment 13 by dimu@chromium.org, Nov 18 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/4e1eaa05ac9ee8240f99d2135dce350d7ac09c43

commit 4e1eaa05ac9ee8240f99d2135dce350d7ac09c43
Author: Jungshik Shin <jungshik@google.com>
Date: Fri Nov 18 00:29:14 2016

Comment 15 by js...@chromium.org, Nov 18 2016

Labels: -Merge-Approved-55 merge-merged-2883
For M54, I have a ICU roll CL up to help review merge request. 
 https://chromereviews.googleplex.com/545847013

Thank you for M55 merge approval. 

Labels: ReleaseBlock-Stable
How critical is the bug for M54? 

Don't think we have another stable refresh planned, users may need to wait until mid week of Dec for M55 roll out.

M55 folks ignore the RBS label. Its intended for efficient M54 triaging effort.

Comment 17 by js...@chromium.org, Nov 18 2016


Thank you for the consideration, ligimole@. 

For people in Turkey, it'd be rather critical. It'll be the worst on Chrome OS because the OS clock is off by an hour. 

1. The time displayed at the lower-right corner will be off. 
2. Time stamps in the history page will be off by an hour.
3. Any Web sites relying on the client-side Javascript to show time will get the time  off by an hour. (gmail seems to be one of them. Google calendar is fine). 

On Chrome OS, all three are the case. On other platforms, #2 is certainly the case and #3 is likely to be the case (I have to check). 


We have about 3 weeks until M55 turns stable. Chrome's time has been off by an hour for about 3 weeks (since the end of October). 

How about this? Even though we're not likely to have an update for M55, it'd not hurt merging 'icu rolling cl' to buildpsec/branches/2840/DEPS  now, would it?  And if we happen to release yet another M54-stable (for another reason - e.g. an extremely critical security issue) or we decide that this issue is critical enough to release another M54 stable, we can get the fix (quickly). 
 

I should have noticed this change sooner (I thought I had subscribed to the IANA timezone announcement list, but it turned out that I hadn't replied to the verification email ....). 
Cc: bustamante@chromium.org
Thanks Jessica for the clarification, we can proceed with the merge once the bug is verified either in canary/beta.I will loop Richard for merge approval.

Meanwhile can you also provide us with the steps to verify.

Comment 19 by js...@chromium.org, Nov 18 2016

Thank you (btw, I'm jungshik at google :-)). 

The verification can be done with the following: 

In JS console, run the following. The result should be 3:00 instead 2:00.

(new Date("10/30/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Istanbul"})
"10/30/2016, 3:00:00 PM"



Comment 20 by js...@chromium.org, Nov 18 2016

An alternative to test: load the attached html and the alert box should show

"10/30/2016, 3:00:00 PM". 

When it's not fixed, it'd show 

"10/30/2016, 2:00:00 PM"
turkeytz.html
239 bytes View Download

Comment 21 by js...@chromium.org, Nov 21 2016

55.0.2883.59 was released with ICU rolled to 5e6ef0 ( https://codereview.chromium.org/2507323002 ). 

Richard, can you verify that it's fixed there?   See the previous two comments as to how to verify. 

Thanks 
We will get this verified in today's canary.

Comment 23 by ajha@chromium.org, Nov 22 2016

Labels: TE-Verified-55.0.2883.59 TE-Verified-M55 TE-Verified-57.0.2926.0 TE-Verified-M57
Thanks jshin@ for verification steps and test file.

Verified the fix on the latest canary(57.0.2926.0) and merge on the latest beta(55.0.2883.59) of Windows-10, Mac OS 10.11.6 and Linux Ubuntu 14.04. This is working as intended as per C#19(JS console output) and C#20(test file).

Attached is the screenshot of the same.
664126.png
31.9 KB View Download

Comment 24 by js...@chromium.org, Nov 23 2016

Thank you, ajha@ for the verification. 
Richard, could you consider merge request to M54? Thank you


Cc: js...@chromium.org
 Issue 669048  has been merged into this issue.
This is too late for M54, but M55 will start rolling out to stable users this week and they'll see the fix then.

Comment 27 by js...@chromium.org, Nov 29 2016

Yeah.. it's Nov 28. 

Sorry,  mustafa175@ and others in Turkey. It seems that you have to wait about a week for the stable release to have this fix (or switch to a beta channel).  
We wouldn't have released a new stable on the 11/23 either, the severity doesn't justify a new stable respin this late in the cycle.  The 11/9 release was the final M54 stable release.

Sorry to the folks affected!  As noted you can switch to Beta or Dev in the mean time, or wait for this fix to roll out with M55.
 Issue 659514  has been merged into this issue.
Labels: -Hotlist-Merge-Review -M-54 -Merge-Review-54
Remove obsolete labels. 

Sign in to add a comment