Simply loading a file:// url doesn't work on devices.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/597a121d5e90c67564f0226d66c7e02984c3df8f commit 597a121d5e90c67564f0226d66c7e02984c3df8f Author: olivierrobin <olivierrobin@chromium.org> Date: Thu Nov 10 16:51:52 2016 Use relative address for images. There is no readon to use absolute address. It is easier with WKWebView to have relative addresses. Also DomDistiller sometaimes escapes URL, so test the images URLs escaped. BUG= 664124 Review-Url: https://codereview.chromium.org/2496553002 Cr-Commit-Position: refs/heads/master@{#431275} [modify] https://crrev.com/597a121d5e90c67564f0226d66c7e02984c3df8f/ios/chrome/browser/reading_list/url_downloader.cc [modify] https://crrev.com/597a121d5e90c67564f0226d66c7e02984c3df8f/ios/chrome/browser/reading_list/url_downloader.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2af01fd026943df1d749b43c311a1cafb1d6693 commit f2af01fd026943df1d749b43c311a1cafb1d6693 Author: olivierrobin <olivierrobin@chromium.org> Date: Mon Nov 14 19:54:00 2016 Use Distilled path instead of DistilledURL. It does not make sense to store the sandbox path for the offline files. Instead, store the path relative to the offline folder. Also rename method to make clear distinction between absolute file path and relative path that can be used in files path or URLs. DistilledURL change semantics. It was the file URL to the local file, it is now a URL that can be loaded to load the file. BUG= 664124 Review-Url: https://codereview.chromium.org/2491383002 Cr-Commit-Position: refs/heads/master@{#431912} [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_download_service.cc [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_download_service.h [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_entry.cc [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_entry.h [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_entry_unittest.cc [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_model.h [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_model_impl.cc [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_model_impl.h [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_model_storage_defaults.mm [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/reading_list_model_unittest.cc [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/url_downloader.cc [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/url_downloader.h [modify] https://crrev.com/f2af01fd026943df1d749b43c311a1cafb1d6693/ios/chrome/browser/reading_list/url_downloader_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9079aef006b0740dd5d0d2cd8b3ad06ad733a20e commit 9079aef006b0740dd5d0d2cd8b3ad06ad733a20e Author: olivierrobin <olivierrobin@chromium.org> Date: Wed Nov 16 08:37:10 2016 Create chrome://offline URL This URL will be used to load distilled pages in Chrome. BUG= 664124 Review-Url: https://codereview.chromium.org/2488153003 Cr-Commit-Position: refs/heads/master@{#432432} [modify] https://crrev.com/9079aef006b0740dd5d0d2cd8b3ad06ad733a20e/ios/chrome/browser/chrome_url_constants.cc [modify] https://crrev.com/9079aef006b0740dd5d0d2cd8b3ad06ad733a20e/ios/chrome/browser/chrome_url_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ade080aed5a40cf5a4af4385144899eb0deff351 commit ade080aed5a40cf5a4af4385144899eb0deff351 Author: olivierrobin <olivierrobin@chromium.org> Date: Wed Nov 16 08:43:40 2016 Make offline directory name public. This is needed to allow the offline loader to find the pages inside this directory. BUG= 664124 Review-Url: https://codereview.chromium.org/2507703002 Cr-Commit-Position: refs/heads/master@{#432434} [modify] https://crrev.com/ade080aed5a40cf5a4af4385144899eb0deff351/ios/chrome/browser/reading_list/url_downloader.cc [modify] https://crrev.com/ade080aed5a40cf5a4af4385144899eb0deff351/ios/chrome/browser/reading_list/url_downloader.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ab336ce9b177b0e70e9175633b8ebf07bff3a21 commit 5ab336ce9b177b0e70e9175633b8ebf07bff3a21 Author: olivierrobin <olivierrobin@chromium.org> Date: Wed Nov 16 17:39:36 2016 Create offline_url_utils This utils will handle all the conversions between offline file path and URLs. BUG= 664124 Review-Url: https://codereview.chromium.org/2506993002 Cr-Commit-Position: refs/heads/master@{#432541} [modify] https://crrev.com/5ab336ce9b177b0e70e9175633b8ebf07bff3a21/ios/chrome/browser/reading_list/BUILD.gn [add] https://crrev.com/5ab336ce9b177b0e70e9175633b8ebf07bff3a21/ios/chrome/browser/reading_list/offline_url_utils.cc [add] https://crrev.com/5ab336ce9b177b0e70e9175633b8ebf07bff3a21/ios/chrome/browser/reading_list/offline_url_utils.h [add] https://crrev.com/5ab336ce9b177b0e70e9175633b8ebf07bff3a21/ios/chrome/browser/reading_list/offline_url_utils_unittest.cc [modify] https://crrev.com/5ab336ce9b177b0e70e9175633b8ebf07bff3a21/ios/chrome/browser/reading_list/reading_list_entry.cc [modify] https://crrev.com/5ab336ce9b177b0e70e9175633b8ebf07bff3a21/ios/chrome/browser/reading_list/url_downloader.cc [modify] https://crrev.com/5ab336ce9b177b0e70e9175633b8ebf07bff3a21/ios/chrome/browser/reading_list/url_downloader.h [modify] https://crrev.com/5ab336ce9b177b0e70e9175633b8ebf07bff3a21/ios/chrome/browser/reading_list/url_downloader_unittest.cc
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/fee4b90e9f6e009edb70b7b272d1198dab7c0a3d commit fee4b90e9f6e009edb70b7b272d1198dab7c0a3d Author: olivierrobin <olivierrobin@google.com> Date: Thu Nov 17 15:02:08 2016
Comment 1 by olivierrobin@chromium.org
, Nov 10 2016Owner: olivierrobin@chromium.org
Status: Started (was: Assigned)