Issue metadata
Sign in to add a comment
|
Regression: Unnecessary black border is seen on tabstrip when entered fullscreen mode.
Reported by
lpa...@etouch.net,
Nov 10 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 56.0.2914.3 (Official Build) b57184fe310b2dd87729c8b08e3e30dde2394195-refs/branch-heads/2914@{#7} (64-bit) OS: Mac (10.12.1, 10.11.6) What steps will reproduce the problem? 1) Launch chrome, open 2-3 new tabs and press Cmd+Ctrl+F (to enter fullscreen mode). 2) Observe the bottom of tabstrip. Unnecessary black border is seen on tabstrip when entered fullscreen mode. Unnecessary black border should not be seen on tabstrip when entered fullscreen mode. This is a Regression issue broken in M-51, below is the bisect info Manual bisect: Good build: 51.0.2663.0 Bad build: 51.0.2664.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/5121a34129f274edc61a288f73f99b39eb06e1e7..b38be38cee2027dcb827ebc61abb23508b8e5d25?pretty=fuller&n=10000 Suspecting: r378367 Note: Issue is not seen on Windows and Linux OS.
,
Nov 10 2016
spqchan@ - PTAL. I'm wondering if the issue is that the stroke color is transparent and is drawing on top of the NSVisualEffectView, and the background behind the NSVEV is black so the stroke appears darker. If that's the case, I'm not exactly sure what the right fix is.
,
Nov 21 2016
Still able to reproduce the issue on Mac 10.11.6 using latest chrome version 57.0.2926.0. spqchan@ Could you please look into this issue. Thanks,
,
Jan 4 2017
Just to update, still able to reproduce the issue on Mac 10.12.2 using latest canary #57.0.2970.0. spqchan@ - Could you please have a look into this issue. Thanks...!!
,
Jan 11 2017
This line is partially transparent - basically it's a partially transparent dark line drawn over the tabstrip's background. The tabstrip's background is an NSVisualEffectView that bleeds through some of the desktop background. When you switch to fullscreen, either the NSVisualEffectView is showing the dark background behind the window, or it's opaque (didn't look in the code). Either way, that line is most-likely going to look different when you're in fullscreen vs. not. Attached is a screenshot where I have a light desktop picture, and have placed a dark region behind part of the tabstrip. If you inspect this image using an app like Photoshop you'll see that the line's color over the dark region is different than it is when it's not. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lpa...@etouch.net
, Nov 10 2016