Issue metadata
Sign in to add a comment
|
Regression: Bottom arrow of the scroll bar remains enabled in add languages overlay.
Reported by
lpa...@etouch.net,
Nov 10 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 56.0.2914.3 (Official Build) b57184fe310b2dd87729c8b08e3e30dde2394195-refs/branch-heads/2914@{#7} 32/64-bit. OS: Windows (7,8,10) Mac (10.11.6, 10.12.1), Linux (14.04 LTS) Steps: 1. Launch chrome and navigate to chrome://md-settings 2. Click on 'Advanced' >> Language >> Add languages, click on the first language checkbox 3. Hit the down arrow key continuously such that the scrollbar reaches the bottom of the language overlay. 4. Now hit the up arrow key continuously to reach the top of the overlay and again repeat step 3. 5. Observe the scrollbar in the language overlay. Actual: Bottom arrow of the scroll bar remains enabled. Expected: Bottom arrow of the scroll bar should be disabled. This is a regression issue broken in M-55, will soon update the other info. Manual Regression Range: 55.0.2868.0 -g 55.0.2869.0 -b
,
Nov 10 2016
,
Nov 11 2016
Unable to reproduce the issue in the following scenarios 1. Windows 10 with chrome version 55.0.2869.0 2. Windows 10 and Mac 10.11.6 with chrome canary version 56.0.2915.0 3. Ubuntu with chrome dev version 56.0.2914.3 Please look at the attached screencast and let us know your observations.
,
Nov 15 2016
,
Nov 15 2016
With response to comment #3: 1) Correction: Above issue is not reproducible on Mac OS (10.11.6, 10.12.1). 2) Rechecked the above issue. It is reproducible on Windows 10 and Linux (Ubuntu 14.04 LTS) OS on latest canary #56.0.2920.0.
,
Nov 16 2016
With response to comment #2: Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/e7cc80667580e40872b03d4f7bf29d0b7e900089..b245b7d270fafab80c2eca0821a01165028b296d?pretty=fuller&n=100 Suspecting: r420283
,
Nov 17 2016
So the actual problem is the up/down keys should focus the previous/next paper checkbox. That's happens to also prevent the scrolling from working properly. Looks like we just need to bind tabIndex in the template items. iron-list has some funky logic that expects this... https://github.com/PolymerElements/iron-list/blob/master/iron-list.html#L1708-L1716
,
Nov 23 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10719a79d0d6cf3cee559771cb5cca8f78024b5d commit 10719a79d0d6cf3cee559771cb5cca8f78024b5d Author: michaelpg <michaelpg@chromium.org> Date: Wed Dec 07 09:05:21 2016 Language settings: fix focus issues * Allow traversal through iron-list elements with up/down arrow keys. For input methods, <Enter> selects that input method. * Tapping anywhere on a togglable row toggles that row. * Make the buttons to open a subpage keyboard-focusable by wrapping their content in <a is="action-link">. * Don't focus the Add Language dialog's Cancel button on opening. * Other minor UI fixes. BUG= 664106 , 668307 , 658279 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2523403003 Cr-Commit-Position: refs/heads/master@{#436894} [modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/add_languages_dialog.html [modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/add_languages_dialog.js [modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp [modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html [modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/ui/webui/resources/cr_elements/compiled_resources2.gyp [add] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/ui/webui/resources/cr_elements/cr_expand_button/compiled_resources2.gyp
,
Dec 9 2016
Issue 641231 has been merged into this issue.
,
Dec 9 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lpa...@etouch.net
, Nov 10 2016