New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664095 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Missing unit tests for ArcRobotAuth

Project Member Reported by pelets...@chromium.org, Nov 10 2016

Issue description

There is no unit test for ArcRobotAuth class. It is tested in browser test, but good practice is to have unit tests as well.


 
Cc: hidehiko@chromium.org pelets...@chromium.org
I think it was already fixed in http://crrev.com/2507073002 ? After refactoring there are dedicated browser tests for ArcRobotAuthCodeFetcher into which ArcRobotAuth was refactored.

Hidehiko, Alexandr, WDYT?
Status: Fixed (was: Assigned)
SGTM. Let's mark fixed.

Comment 3 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment