New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664094 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Error message is seen missing on maximising the User manager window

Project Member Reported by mmanchala@chromium.org, Nov 10 2016

Issue description

Version: 56.0.2914.3
OS: Ubuntu 14.04

What steps will reproduce the problem?
1.Launch chrome -> Sign into Profile
2.Now Create/import supervised user -> Then click on avatar Menu and choose option "Exit and childlock" (For First time Sign in Page is seen so enter correct password then profile gets unlocked and now again choose option "Exit and childlock" )
3.Now Switch person window is displayed -> Click on Locked profile -> Enter Wrong password -> Now Maximize the window then enter wrong password and observe for Error Message(Please refer Video). 
 

Expected:  Error Message should be seen on maximising the User manager window
Actual:  Instead Error Message is seen missing


This is Regression Issue broken in M-56

Manual good and Bad Builds:
Good Build: 56.0.2909.0
Bad Build:  56.0.2910.0

Note : Unable to provide narrow bisect as sign in to chrome in chromium builds is not possible, hence providing Manual change log info.

MANUAL CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/56.0.2909.0..56.0.2910.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/2467783002 from Manual Changelog

@alemate : Please feel free to re-assign if its not related to your change

 
Actual_errorMessage.ogv
138 KB View Download
Expected_ErrorMessage.ogv
1.1 MB View Download

Comment 1 Deleted

Labels: OS-Mac
Note:
1.Issue is also seen on Windows and Mac OS
2.Issue is also seen on minimising the window i.e.

After step 3  Minimise the window-> enter wrong password and observe for Error Message (Please refer video)

Comment 3 by ajha@chromium.org, Nov 14 2016

Cc: xiy...@chromium.org jdufault@chromium.org
Issue is still seen on Linux chrome version 57.0.2929.0

alemate@, Could you please take a look
Cc: msrchandra@chromium.org nyerramilli@chromium.org
 Issue 668372  has been merged into this issue.
This issue is tagged as Stable blocker , please have a fix ASAP.
alemate@, Could you please take a look at this stable blocker.
alemate@, Gentle Ping!
Status: Started (was: Assigned)
Cl is on review: https://codereview.chromium.org/2590823005
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffc683508cd14f45a6fe8463224795a5c48c3c18

commit ffc683508cd14f45a6fe8463224795a5c48c3c18
Author: alemate <alemate@chromium.org>
Date: Wed Dec 21 23:05:46 2016

Account Picker: fix window resize.

When AccountPicker screeen is resized, its error bubble has to be repositioned.
This is done 'reusing existing content' of error bubble, which led to
exception.

BUG= 664094 

Review-Url: https://codereview.chromium.org/2590823005
Cr-Commit-Position: refs/heads/master@{#440256}

[modify] https://crrev.com/ffc683508cd14f45a6fe8463224795a5c48c3c18/ui/login/account_picker/screen_account_picker.js

Labels: Merge-Request-56
Status: Fixed (was: Started)

Comment 13 by dimu@chromium.org, Dec 22 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 22 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ec7fe2030d838c80b234aac17be5c0d7871e835

commit 1ec7fe2030d838c80b234aac17be5c0d7871e835
Author: Alexander Alekseev <alemate@chromium.org>
Date: Thu Dec 22 22:46:46 2016

Account Picker: fix window resize.

When AccountPicker screeen is resized, its error bubble has to be repositioned.
This is done 'reusing existing content' of error bubble, which led to
exception.

BUG= 664094 

Review-Url: https://codereview.chromium.org/2590823005
Cr-Commit-Position: refs/heads/master@{#440256}
(cherry picked from commit ffc683508cd14f45a6fe8463224795a5c48c3c18)

Review-Url: https://codereview.chromium.org/2596423002 .
Cr-Commit-Position: refs/branch-heads/2924@{#604}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/1ec7fe2030d838c80b234aac17be5c0d7871e835/ui/login/account_picker/screen_account_picker.js

Labels: TE-Verified-M56 TE-Verified-56.0.2924.51
Tested the same on win10 mac 10.12.2 and Linux 14.04 using chrome version 56.0.2924.51 -  Error Message is seen on maximising the User manager window

Please find the screenshot

Fix works as expected
Screenshot from 2017-01-04 14:06:10.png
129 KB View Download

Sign in to add a comment