New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663983 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 602708
issue 654064
issue 663988



Sign in to add a comment

Idle suspension of media elements is disabled on Windows.

Project Member Reported by jbau...@chromium.org, Nov 10 2016

Issue description

We can keep a lot of unnecessary video decoders and threads around.
 
Blocking: 654064

Comment 2 by w...@chromium.org, Nov 10 2016

Blocking: 663988
Blocking: 602708
jbauman@: The basic path here is well-trodden. The resources needed to draw a frame should be owned by a GLImage, which is then bound to the texture. I removed the requirement to destroy GLImages recently, so they can always outlive the VDA safely now.
Owner: jbau...@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d

commit 2438e873e9f0e2788cf20ab89dcc6d8f6a45224d
Author: jbauman <jbauman@chromium.org>
Date: Tue Nov 15 04:45:19 2016

Reenable idle suspension of media elements on Windows.

Use GLImages to hold references from the DXVA picture buffer to the
EGLStream or EGLSurface. This allows their contents to outlive the video
decoder.

BUG= 663983 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2495753002
Cr-Commit-Position: refs/heads/master@{#432101}

[modify] https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d/media/gpu/dxva_picture_buffer_win.cc
[modify] https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d/media/gpu/dxva_picture_buffer_win.h
[modify] https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d/media/gpu/gpu_video_decode_accelerator_factory.cc
[modify] https://crrev.com/2438e873e9f0e2788cf20ab89dcc6d8f6a45224d/media/gpu/ipc/service/gpu_video_decode_accelerator.cc

Status: Fixed (was: Started)

Sign in to add a comment