New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663975 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX


Sign in to add a comment

Move all Page Info strings into page_info_strings.grdp

Project Member Reported by lgar...@chromium.org, Nov 10 2016

Issue description

Some of them are still in generated_resources.grd
 
Blocking: 657231
And are they: IDS_PAGE_INFO_COOKIES, IDS_PAGE_INFO_SITE_SETTINGS_LINK, IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_NO_CT and IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_VERIFIED? There are also some with IDS_PAGEINFO_
They're in a few places, most of them still called IDS_WEBSITE_SETTINGS_* in `generated_resources.grd`
Blockedon: 704788
Blockedon: 708691
Blockedon: 709701
Status: Started (was: Available)
Blockedon: 716296
Blockedon: 716300
Blockedon: 716302
Blockedon: 716303
Summary: Move all Page Info strings into page_info_strings.grdp (was: Move all Page Info strings into pageinfo_strings.grdp)
Blockedon: 716305
Cc: -lgar...@chromium.org
Owner: lgar...@chromium.org
Blockedon: 717802
Project Member

Comment 16 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc1d5e5df6ef53ecc87135178352b22665296c3a

commit fc1d5e5df6ef53ecc87135178352b22665296c3a
Author: lgarron <lgarron@chromium.org>
Date: Wed May 03 23:15:21 2017

Move all Page Info strings into page_info_strings.grdp

This CL does the following:
- Move strings into page_info_strings.grdp
- Organize the strings into sections with comment headings, based on the order and role they have in the UI.
- Remove old "chrome/grit/generated_resources.h" includes in C++ files where possible.
- Replace IDS_PAGE_INFO_TITLE_SITE_DATA with IDS_PAGE_INFO_COOKIES ( crbug.com/716296 )
- Remove dead strings and their associated code ( crbug.com/709701 )
- Rename remaining IDS_PAGEINFO_* strings to IDS_PAGE_INFO_* ( crbug.com/716305 )
- Unfork IDS_PAGE_INFO_NON_SECURE_TRANSPORT into IDS_PAGEINFO_NOT_SECURE_SUMMARY

BUG= 663975 ,  709701 ,  716296 ,  716296 ,  716305 
TBR=meacer@chromium.org, asanka@chromium.org, kkhorimoto@chromium.org

Review-Url: https://codereview.chromium.org/2849713003
Cr-Commit-Position: refs/heads/master@{#469190}

[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/app/chromium_strings.grd
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/app/generated_resources.grd
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/android/page_info/connection_info_popup_android.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/login/login_handler.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/login/login_handler_unittest.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/page_info/page_info_infobar_delegate.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/page_info/page_info_ui.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/page_info/page_info_ui.h
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/page_info/permission_menu_model.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/views/certificate_selector.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/components/components_chromium_strings.grd
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/components/components_google_chrome_strings.grd
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/components/components_strings.grd
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/components/page_info_strings.grdp
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/ios/chrome/browser/ui/dialogs/nsurl_protection_space_util.mm
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/ios/chrome/browser/ui/dialogs/nsurl_protection_space_util_unittest.mm
[modify] https://crrev.com/fc1d5e5df6ef53ecc87135178352b22665296c3a/ios/chrome/browser/ui/omnibox/page_info_model.cc

Labels: Hotlist-EnamelAndFriendsFixIt
Status: Fixed (was: Started)
Looks like this is done by c16
 Issue 679976  has been merged into this issue.

Sign in to add a comment