New issue
Advanced search Search tips

Issue 663961 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 672271

Blocking:
issue 663118
issue 663141
issue 663144
issue 668266
issue 670791
issue 674997



Sign in to add a comment

No bisectors for new macbook airs and macbook pros

Project Member Reported by sullivan@chromium.org, Nov 10 2016

Issue description

Dave, what is the plan for adding these? Will we split devices between swarming pool and old bisect waterfall?
 
Blocking: 663118
Blocking: 663141
Blocking: 663144
Cc: simonhatch@chromium.org
Note there is a doc on setting up a new bisector here: https://docs.google.com/document/d/1F_qEh_DBSQktlQfc8S6s3jw3cvtpmAirP5znN0ZadFY/edit

Dave is still on vacation. Emily or Simon, is this something one of you would be willing to take on?
Blocking: 668266
Owner: simonhatch@chromium.org
I'm making my way through my bug list so I can probably take this later in the week or early next week.
Blocking: 670791

Comment 8 by dtu@chromium.org, Dec 6 2016

The hostnames are:

MacBook Air:
build192-b4
build193-b4
build194-b4
build195-b4
build196-b4

MacBook Pro:
build197-b4
build198-b4
build199-b4
build200-b4
build201-b4

I believe we'll want to split them, with 3 of each in buildbot and 2 in swarming.

Comment 9 by dtu@chromium.org, Dec 7 2016

Blockedon: 672271
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/fe6e565da209d1fa71e2bf0c0c095987cedd0c18

commit fe6e565da209d1fa71e2bf0c0c095987cedd0c18
Author: Dave Tu <dtu@chromium.org>
Date: Tue Dec 13 00:21:41 2016

Owner: dtu@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/8e3392fe47d4a88ff7de7a550dba6c7b15dbaaca

commit 8e3392fe47d4a88ff7de7a550dba6c7b15dbaaca
Author: Dave Tu <dtu@chromium.org>
Date: Tue Dec 13 06:32:18 2016

[perf] Fix bot hostnames for Mac Pro bisect bots.

BUG= 663961 

Change-Id: Iaf1760081ad9955794ee544b8b6e343b06f9ad94
Reviewed-on: https://chromium-review.googlesource.com/419125
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>

[modify] https://crrev.com/8e3392fe47d4a88ff7de7a550dba6c7b15dbaaca/masters/master.tryserver.chromium.perf/slaves.cfg

Blocking: 674997
What's left here? I see these builders are up, do we just need to add dashboard support?
Yeah, I think we just need dashboard support + rerun bisects on blocked bugs.
Added them to the internal bot map. They were there in external, not sure what the difference is but they didn't show up in the bisect list until I added they to the internal bot map.

Re-kicked all the bisects for any bugs still open, looks like the bots are chugging away:
https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_pro_perf_bisect/builds/0


One small issue still is that when you go to bisect on air or pro, we still default to mac_10_11_perf_bisect, I suspect something needs tweaking in the bisect bot guessing code in the dashboard.
Ok tweaked the BISECT_BOT_MAP, bisect-form gets filled out properly now. I think this can be closed.
Status: Fixed (was: Untriaged)
Components: Speed>Bisection

Sign in to add a comment