New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663960 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 605129

Blocking:
issue 429053



Sign in to add a comment

GPU process crash running http://files.unity3d.com/jonas/benchmarks/5.5-asm-release/

Project Member Reported by zmo@chromium.org, Nov 10 2016

Issue description

To repro:
 -Open http://files.unity3d.com/jonas/benchmarks/5.5-asm-release/
 -Select only “Animation & Skinning”
 -Click Start

[163229:163229:1109/161935:FATAL:gles2_cmd_decoder.cc(13667)] Check failed: texture->IsLevelCleared(target, level). 
#0 0x7fecc9960cce base::debug::StackTrace::StackTrace()
#1 0x7fecc9984feb logging::LogMessage::~LogMessage()
#2 0x7fecc673fefd gpu::gles2::GLES2DecoderImpl::DoCompressedTexSubImage()
#3 0x7fecc66f538f gpu::gles2::GLES2DecoderImpl::HandleCompressedTexSubImage2DBucket()
#4 0x7fecc6724f5e gpu::gles2::GLES2DecoderImpl::DoCommandsImpl<>()
#5 0x7fecc66cbb76 gpu::CommandParser::ProcessCommands()
#6 0x7fecc66cd1f5 gpu::CommandExecutor::PutChanged()
#7 0x7fecc66cc506 gpu::CommandBufferService::Flush()
#8 0x7fecc67fac75 gpu::GpuCommandBufferStub::OnAsyncFlush()
#9 0x7fecc67faa10 _ZN3IPC8MessageTI35GpuCommandBufferMsg_AsyncFlush_MetaSt5tupleIJijSt6vectorIN2ui11LatencyInfoESaIS5_EEEEvE8DispatchIN3gpu20GpuCommandBufferStubESC_vMSC_FvijRKS7_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#10 0x7fecc67f8f7d gpu::GpuCommandBufferStub::OnMessageReceived()
#11 0x7fecc847d079 IPC::MessageRouter::RouteMessage()
#12 0x7fecc67f3263 gpu::GpuChannel::HandleMessageHelper()
#13 0x7fecc67f3012 gpu::GpuChannel::HandleMessage()
#14 0x7fecc9961806 base::debug::TaskAnnotator::RunTask()
#15 0x7fecc9991d1d base::MessageLoop::RunTask()
#16 0x7fecc99920a8 base::MessageLoop::DeferOrRunPendingTask()
#17 0x7fecc99924bb base::MessageLoop::DoWork()
#18 0x7fecc999450a base::(anonymous namespace)::WorkSourceDispatch()
#19 0x7fecc2cbee04 g_main_context_dispatch
#20 0x7fecc2cbf048 <unknown>
#21 0x7fecc2cbf0ec g_main_context_iteration
#22 0x7fecc9994266 base::MessagePumpGlib::Run()
#23 0x7fecc9991a01 base::MessageLoop::RunHandler()
#24 0x7fecc99c1230 base::RunLoop::Run()
#25 0x7fecc6ebbefc content::GpuMain()
#26 0x7fecc79e0577 content::RunNamedProcessTypeMain()
#27 0x7fecc79e0feb content::ContentMainRunnerImpl::Run()
#28 0x7fecc79df960 content::ContentMain()
#29 0x7fecca3e01dd ChromeMain
#30 0x7fecc00aef45 __libc_start_main
#31 0x7fecca3e00b9 <unknown>
 

Comment 1 by kbr@chromium.org, Nov 10 2016

Blockedon: 605129

Comment 2 by kbr@chromium.org, Nov 10 2016

Not clear why sdk/tests/conformance/extensions/webgl-compressed-texture-s3tc.html didn't catch this regression. This is run on the GPU.FYI bots as part of the WebGL 2.0 conformance tests. See any webgl2_conformance_tests run on https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28NVIDIA%29 , for example:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28NVIDIA%29/builds/44975

https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28NVIDIA%29/builds/44975/steps/webgl2_conformance_tests%20on%20NVIDIA%20GPU%20on%20Linux%20on%20Linux/logs/stdio

https://chromium-swarm.appspot.com/user/task/32646cfd90f90a10

and search for WebglConformance_conformance_extensions_webgl_compressed_texture_s3tc . It runs successfully without any GPU process crashes.

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5219f45e8e6755153240985d4adeae6d27d69db7

commit 5219f45e8e6755153240985d4adeae6d27d69db7
Author: zmo <zmo@chromium.org>
Date: Fri Nov 11 21:03:16 2016

Fix a bug in compressed texture code path.

If we specify a texture using texStorage, the texture is uninitialized,
so if we call compressedTexSubImage, we need to consider the situation.

BUG= 663960 
TEST=webgl2_conformance (in https://github.com/KhronosGroup/WebGL/pull/2142)
R=piman@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2497013002
Cr-Commit-Position: refs/heads/master@{#431642}

[modify] https://crrev.com/5219f45e8e6755153240985d4adeae6d27d69db7/gpu/command_buffer/service/gles2_cmd_decoder.cc

Comment 4 by zmo@chromium.org, Nov 11 2016

Status: Fixed (was: Assigned)
Components: -Internals>GPU>WebGL Blink>WebGL

Sign in to add a comment