New issue
Advanced search Search tips

Issue 663951 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Move remote_channel_main verbose logging flag into launch script, and add general blimp verbose logging flag

Project Member Reported by w...@chromium.org, Nov 10 2016

Issue description

For debugging purposes it's helpful to have the launch script enable verbose logging for all Blimp components, for now.

We should:

1. Remove the in-code hack at https://cs.chromium.org/chromium/src/blimp/engine/app/blimp_content_main_delegate.cc?q=verbose+file:%5Esrc/blimp/engine/&sq=package:chromium&l=35.

2. Add an equivalent flag to https://cs.chromium.org/chromium/src/blimp/engine/start_engine.sh?sq=package:chromium&l=21

3. Additionally add "blimp*=1" to get verbose logging for blimp/ components.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcfdf7d70ba770ea2f7242a029d8a2d361533569

commit dcfdf7d70ba770ea2f7242a029d8a2d361533569
Author: steimel <steimel@chromium.org>
Date: Thu Nov 10 02:29:36 2016

Move remote_channel_main logging flag into launch script and add blimp module verbose logging

BUG= 663951 

Review-Url: https://codereview.chromium.org/2488123002
Cr-Commit-Position: refs/heads/master@{#431146}

[modify] https://crrev.com/dcfdf7d70ba770ea2f7242a029d8a2d361533569/blimp/engine/app/blimp_content_main_delegate.cc
[modify] https://crrev.com/dcfdf7d70ba770ea2f7242a029d8a2d361533569/blimp/engine/start_engine.sh

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcfdf7d70ba770ea2f7242a029d8a2d361533569

commit dcfdf7d70ba770ea2f7242a029d8a2d361533569
Author: steimel <steimel@chromium.org>
Date: Thu Nov 10 02:29:36 2016

Move remote_channel_main logging flag into launch script and add blimp module verbose logging

BUG= 663951 

Review-Url: https://codereview.chromium.org/2488123002
Cr-Commit-Position: refs/heads/master@{#431146}

[modify] https://crrev.com/dcfdf7d70ba770ea2f7242a029d8a2d361533569/blimp/engine/app/blimp_content_main_delegate.cc
[modify] https://crrev.com/dcfdf7d70ba770ea2f7242a029d8a2d361533569/blimp/engine/start_engine.sh

Status: Fixed (was: Assigned)

Sign in to add a comment