"PreviewsIODataTest.TestShouldAllowPreview" is flaky |
||||
Issue description"PreviewsIODataTest.TestShouldAllowPreview" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNAsSBUZsYWtlIilQcmV2aWV3c0lPRGF0YVRlc3QuVGVzdFNob3VsZEFsbG93UHJldmlldww. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 9 2016
Looks like this started here: https://codereview.chromium.org/2477073002 I'm going to revert that change and hopefully things clear up.
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/032b6e1db3c05363d2db3d2323573ff3fad3512a commit 032b6e1db3c05363d2db3d2323573ff3fad3512a Author: dpranke <dpranke@chromium.org> Date: Thu Nov 10 00:16:22 2016 Revert "Adding UMA to track previews opt outs and blacklist eligibility" > Adding UMA to track previews opt outs and blacklist eligibility > > This CL adds UMA to track the reason that a user was not shown a preview > (or if it was allowed) and whether a user opts out when shown a preview. > > BUG= 647717 > Committed: https://crrev.com/cc61592651c3018a146387f691bc4cbd60f7807b > Cr-Commit-Position: refs/heads/master@{#431020} BUG= 663940 , 647717 TBR=ryansturm@chromium.org,asvitikine@chromium.org NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2491803002 Cr-Commit-Position: refs/heads/master@{#431091} [modify] https://crrev.com/032b6e1db3c05363d2db3d2323573ff3fad3512a/components/previews/core/BUILD.gn [modify] https://crrev.com/032b6e1db3c05363d2db3d2323573ff3fad3512a/components/previews/core/previews_black_list.cc [modify] https://crrev.com/032b6e1db3c05363d2db3d2323573ff3fad3512a/components/previews/core/previews_black_list.h [modify] https://crrev.com/032b6e1db3c05363d2db3d2323573ff3fad3512a/components/previews/core/previews_black_list_unittest.cc [modify] https://crrev.com/032b6e1db3c05363d2db3d2323573ff3fad3512a/components/previews/core/previews_io_data.cc [modify] https://crrev.com/032b6e1db3c05363d2db3d2323573ff3fad3512a/components/previews/core/previews_io_data_unittest.cc [modify] https://crrev.com/032b6e1db3c05363d2db3d2323573ff3fad3512a/tools/metrics/histograms/histograms.xml
,
Nov 10 2016
,
Nov 10 2016
This was caused by evaluation order issues inherent to some C++ compilers. Resubmitting with fix.
,
Nov 10 2016
Moving this out of the sheriffing queue, because it is being worked on.
,
Nov 10 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Nov 9 2016