Test permissions UI surfaces on desktop |
||||
Issue descriptionCurrently, all permissions testing on desktop mocks out the actual permission prompt UI surface, and replaces it with a stub. There is no testing of interactions with the prompt via the keyboard, or clicking on buttons. We should have end to end tests on all desktop platforms like we have on Android where a prompt is triggered and user interaction with the prompt is tested for correctness. This will avoid bugs like crbug.com/653497 and crbug.com/653498 .
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38424d53080c397f8cc13c6581fe937070922ac0 commit 38424d53080c397f8cc13c6581fe937070922ac0 Author: tapted <tapted@chromium.org> Date: Thu Mar 16 01:16:45 2017 Add "interactive" UI integration tests for PermissionRequestManager. Existing PermissionRequestManager tests use a MockPermissionPromptFactory which replaces the code that generates actual UI with stubs. To get coverage of the UI creation code, and to allow the set of permission prompts to be easily "invoked" for UI review, extend PermissionRequestManagerBrowserTest with one that uses "real" UI rather than a mock. Then, add "Dialog" BrowserTests for a range of permission types that can be requested. These are run on the bots or (optionally) interactively with a command such as `browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive --dialog=PermissionDialogTest.InvokeDialog_multiple` BUG= 605667 , 663935 Review-Url: https://codereview.chromium.org/2569703004 Cr-Commit-Position: refs/heads/master@{#457296} [modify] https://crrev.com/38424d53080c397f8cc13c6581fe937070922ac0/chrome/browser/media/webrtc/media_stream_devices_controller.h [modify] https://crrev.com/38424d53080c397f8cc13c6581fe937070922ac0/chrome/browser/permissions/permission_request_manager_browsertest.cc
,
Jun 7 2017
,
Nov 10 2017
,
Feb 18 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by raymes@chromium.org
, Nov 29 2016