New issue
Advanced search Search tips

Issue 663895 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

LayoutPoint.roundedLayoutPoint() is a no-op, should be removed

Project Member Reported by mustaq@chromium.org, Nov 9 2016

Issue description

This is a misnomer: there is no rounding other than the one imposed by LayoutUnit precision.

Nuke the method, and replace all roundedLayoutPoint(*) with LayoutPoint(*).
 

Comment 1 by mustaq@chromium.org, Nov 10 2016

Owner: xing...@intel.com
Status: Assigned (was: Untriaged)
Assigning to xing.xu@intel.com who already have a fix in progress:
https://codereview.chromium.org/2491703004/

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8906d8c65b7ca22d648fdacda5f01af12a11cb9

commit c8906d8c65b7ca22d648fdacda5f01af12a11cb9
Author: xing.xu <xing.xu@intel.com>
Date: Fri Nov 11 00:28:45 2016

Replace roundedLayoutPoint with LayoutPoint

roundedLayoutPoint is a noop.
And  crbug.com/321237  is fixed, so also remove related FIXME.

BUG= 663895 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2491703004
Cr-Commit-Position: refs/heads/master@{#431408}

[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/dom/Touch.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/events/MouseRelatedEvent.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/c8906d8c65b7ca22d648fdacda5f01af12a11cb9/third_party/WebKit/Source/platform/geometry/LayoutPoint.h

Comment 3 by mustaq@chromium.org, Nov 11 2016

Labels: Hotlist-CodeHealth
Status: Fixed (was: Assigned)

Sign in to add a comment