Awkward behavior with Physical Web in Chrome Today View widget |
||||||||||||||
Issue descriptionVersion: 54.0.2840.91 (Stable) OS: iOS 10.0 What steps will reproduce the problem? (1) Add the Chrome Today View widget. (2) Go near a Physical Web beacon broadcasting a URL. (3) Look at the widget. Results appear cut off. What is the expected result? You should see the full list of nearby URLs (and when opting in, the full opt-in message). What happens instead? Results appear cut off. The only way to see the full list is to toggle the 'Show More' button on the widget, but this does not reliably toggle. See these screenshots for what currently happens: Opt-in dialog: go/pw-today-opt-in Result listing 1: go/pw-today-result-1 Result listing 2: go/pw-today-result-2 Please use labels and text to provide additional information.
,
Nov 10 2016
,
Nov 30 2016
We're getting comments on our Physical Web mailing list complaining about this. Is there any news on this? Hopefully a fix is coming?
,
Nov 30 2016
I will check this tomorrow
,
Dec 2 2016
Any chance we can get an update before the weekend?
,
Dec 2 2016
This will be hard. I checked the code and the resize method is correctly called. I am not sure why the widget is not resized. The bug seems to happen when you press the button too early after it is displayed.
,
Dec 2 2016
,
Dec 2 2016
Seems similar to http://stackoverflow.com/questions/40233594/todays-extension-ios10-show-more-less Testing solution.
,
Dec 2 2016
I will do a tentative fix based on the SO solution so we can test on canary.
,
Dec 2 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/79e2f29010f9dbb42450766d2e1714162a40b17b commit 79e2f29010f9dbb42450766d2e1714162a40b17b Author: olivierrobin <olivierrobin@google.com> Date: Fri Dec 02 17:04:42 2016
,
Dec 2 2016
Submitted a CL. Can you test canary on Monday? If this is fixed, I will cherry-pick to 56.
,
Dec 2 2016
Great! Thanks so much for chasing this down. Happy to test on Monday.
,
Dec 5 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/419b2729f89c05d2b2e29b8ff61bf5a0a56f5314 commit 419b2729f89c05d2b2e29b8ff61bf5a0a56f5314 Author: olivierrobin <olivierrobin@google.com> Date: Mon Dec 05 12:13:36 2016
,
Dec 6 2016
I tried this with the latest Canary build (57.0.2939.0 Canary), not sure if it had your changes in it yet but the widget still doesn't expand reliably for me. I'll try again tomorrow.
,
Dec 6 2016
The canary has my change. I tested it and did not see issue. When you upgrade, can you ensure that Springboard is reloaded (either reboot the phone or change phone language). Do you have multiple Chrome widgets (interactions may cause problems) Do you have more than 3 beacons visible and should the resize be bigger than the screen? Thanks for these elements.
,
Dec 6 2016
I recorded a video showing the bug on my device (iPhone 6s, iOS 10.1): https://drive.google.com/a/google.com/file/d/0B9RNNlGSHjA9bE5WNVh3bHdXM0k/view?usp=sharing This was recorded just after rebooting, and I've disabled all other Chrome widgets. There are ~5 beacons nearby, though I still see the bug even in onboarding mode so the number of beacons probably isn't relevant.
,
Dec 7 2016
OK, problem arise when you dismiss/reopen the widget in expanded mode. I will try to see what happens in that scenario
,
Dec 7 2016
I made some more tests, and I have a very speculative fix. This should be in canary tomorrow, if you can test.
,
Dec 7 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c127cae7cb7efe5a66cee369fb00b80dbe4d80c8 commit c127cae7cb7efe5a66cee369fb00b80dbe4d80c8 Author: olivierrobin <olivierrobin@google.com> Date: Wed Dec 07 18:36:02 2016
,
Dec 7 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c127cae7cb7efe5a66cee369fb00b80dbe4d80c8 commit c127cae7cb7efe5a66cee369fb00b80dbe4d80c8 Author: olivierrobin <olivierrobin@google.com> Date: Wed Dec 07 18:36:02 2016
,
Dec 7 2016
I tested again with Olivier's change that just landed ("Constrain the size of the NC widget"). I couldn't repro the Show More/Less bug anymore, but I'm seeing a different bug where the contents of the widget fail to render:
https://drive.google.com/open?id=0B9RNNlGSHjA9ZldQemVUTl9OY1U
This seems to happen more frequently if I expand the widget and then quickly swipe back to the home screen, then back to the Today view.
,
Dec 8 2016
I propose to close this bug So I can request for merge on this. I cannot reproduce consistently the not rendering issue, but I will investigate more. Please tell me if you have reliable reproduction steps.
,
Dec 8 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 8 2016
,
Dec 8 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 10 2016
You tried to cherry pick this by passing "-a 56.0.2924": https://uberchromegw.corp.google.com/i/internal.bling.tryserver/builders/beta-cherry-picker/builds/1012 You need to pass "-a 2924" instead.
,
Dec 10 2016
Yes, I noticed that. But as I have 3 CL to cherry-pick, I decided to postpone to Monday. BTW, it would be useful to be able to specify multiple CLs to the cherry-picker.
,
Dec 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/a2a9049af6b7ccf72cf8576b993820e4f98b0190 commit a2a9049af6b7ccf72cf8576b993820e4f98b0190 Author: olivierrobin <olivierrobin@google.com> Date: Fri Dec 02 17:04:42 2016
,
Dec 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/806ea6f6b0822ea47498be209ed10e09e7435ae0 commit 806ea6f6b0822ea47498be209ed10e09e7435ae0 Author: olivierrobin <olivierrobin@google.com> Date: Mon Dec 05 12:13:36 2016
,
Dec 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/768cae66c7dc68cdf7e1a5261b95164df46c49f0 commit 768cae66c7dc68cdf7e1a5261b95164df46c49f0 Author: olivierrobin <olivierrobin@google.com> Date: Wed Dec 07 18:36:02 2016
,
Dec 14 2016
Verified on clean install on 57.0.2950.0 canary iPhone6Plus iOs 10.2, iPhone6 iOS 10.0.3. Looks good.Results are not cut off.
,
Dec 14 2016
Verified on a clean install of build 56.0.2924.28 beta on iPhone6Plus iOS 10.2, iPhone7 iOs 10.0.3 Looks good.Results are not cut off.Tapping On tapping "Show More" drops down the list of beacons available and also the "Show More Results" text.
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
,
Jan 25 2017
Current behavior on build 56.0.2924.73 dev on iPhone 6+ iOS 10.2.1 https://drive.google.com/open?id=0B6GVWQnhaMClbXpHNmF6c0R1STg
,
Jan 30 2017
Fix is in M-57. Some parts were not cherry-picked to M-56.
,
Feb 27 2017
https://drive.google.com/open?id=0B6GVWQnhaMClXzBidV9rRTI1dDA Verified on build 57.0.2987.83 dev on iPhone 6+ iOS 10.2.1 , iPad Pro iOS 10.2.1 . The copied link is present.Hence the full list of nearby URLs can be seen only if "Show More" is tapped on. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by animohan@chromium.org
, Nov 9 2016