New issue
Advanced search Search tips

Issue 663859 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
chrome-client-infra-backlog


Sign in to add a comment

Editing OWNERS files should not require a recompile or running layout tests on the blink bots

Project Member Reported by esprehn@chromium.org, Nov 9 2016

Issue description

Labels: -Pri-3 Pri-2
The bots all seem to print:

analyze analyze
No compile necessary 

but the *_chromium_rel_ng bots don't seem to be respecting that and are compiling anyway:

https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/328779
Cc: phajdan.jr@chromium.org
Pawel, who is current expert on analyze that we should CC for bugs like this?
Mergedinto: 595176
Status: Duplicate (was: Untriaged)
Cc: katthomas@chromium.org andyb...@chromium.org
Components: -Infra>CQ Infra>Client>Chrome
Status: Available (was: Duplicate)
The buildbot log for that build is gone, but the equivalent build on milo/logdog is:

https://luci-milo.appspot.com/buildbot/tryserver.chromium.win/win_chromium_rel_ng/328779

and that points to:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_chromium_rel_ng%2F328779%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout

From that, you can see that analyze worked correctly and reported "no compile necessary".

Unfortunately, the logic in the chromium recipe for handling blink tests bypasses analyze, so it ran them anyway.

We need to change the recipe so that logic goes through analyze as well.
Cc: -andyb...@chromium.org
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -phajdan.jr@chromium.org liaoyuke@chromium.org
+yuke, since you're looking at the general case of this. If you've got a bug going for that work, feel free to merge this into that.
Cc: -katthomas@chromium.org
Status: Available (was: Untriaged)
Added to the CCI backlog hotlist and marked available for now.
Labels: -Hotlist-Recharge-Cold
Owner: liaoyuke@chromium.org
Status: Assigned (was: Available)
Cc: -liaoyuke@chromium.org
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment