New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663855 link

Starred by 5 users
Status: Fixed
Owner: ----
Closed: Feb 2017
Cc:
█ robhogan@chromium.org
qyears...@chromium.org
dmazz...@chromium.org
kojii@chromium.org
ksakamoto@chromium.org
liyuqian@google.com
haraken@chromium.org
e...@chromium.org
drott@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 601332



Sign in to add a comment

7 tests in fast/text/ellipsis-{l,r}tr-text-in-{l,r}tl-flow*.html are flaky when run in random order

Project Member Reported by jeffcarp@chromium.org, Nov 9 2016 
The tests:

fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition.html
fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition.html
fast/text/ellipsis-rtl-text-in-ltr-flow-underline.html
fast/text/ellipsis-rtl-text-in-ltr-flow.html
fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition.html
fast/text/ellipsis-rtl-text-in-rtl-flow-underline.html
fast/text/ellipsis-rtl-text-in-rtl-flow.html
fast/text/ellipsis-stroked.html

appear to be flaky when run in random order. Steps to reproduce:

This should pass consistently:
Tools/Scripts/run-webkit-tests fast/text/

This should fail intermittently:
Tools/Scripts/run-webkit-tests fast/text/ --order=random

We're working on removing order dependency from Blink layout tests. More context here:
https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit

Comment 1 by qyears...@chromium.org, Nov 14 2016

Cc: robhogan@chromium.org

Comment 2 by jeffcarp@chromium.org, Nov 14 2016

Description: Show this description

Comment 3 by e...@chromium.org, Nov 21 2016 

Flakiness is caused by running fast/text/ellipsis-platform-font-change.html prior to any of the other ellipsis tests.

Comment 4 by e...@chromium.org, Nov 21 2016

Cc: drott@chromium.org kojii@chromium.org
Labels: -Pri-3 Pri-2
Not limited to ellipsis-platform-font-change.
Using ellipsis with a WebFont leaves state that affect subsequent tests using ellipsis.

Upping priority as this might not be limited to tests.

Comment 5 by jeffcarp@chromium.org, Nov 29 2016 

After testing on macOS I found that fast/text/ellipsis-stroked.html failed 18 out of 36 test runs. Example build:
https://luci-milo.appspot.com/buildbot/chromium.fyi/WebKit%20Mac%20-%20RandomOrder/37

It seems related so I'm going to add it to this bug.

Comment 6 by jeffcarp@chromium.org, Nov 29 2016

Description: Show this description
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b8595351264b872ebf3b4c1aa13666641e3b3c6

commit 8b8595351264b872ebf3b4c1aa13666641e3b3c6
Author: jeffcarp <jeffcarp@chromium.org>
Date: Wed Nov 30 19:38:57 2016

Add 2 Mac flaky tests to RandomOrderExpectations

BUG= 663855 , 669693 

Review-Url: https://codereview.chromium.org/2541703002
Cr-Commit-Position: refs/heads/master@{#435379}

[modify] https://crrev.com/8b8595351264b872ebf3b4c1aa13666641e3b3c6/third_party/WebKit/LayoutTests/RandomOrderExpectations

Comment 8 by loyso@chromium.org, Jan 6 2017 

 Issue 678388  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e285562f783c806c764b11fcc48d638843c0f64

commit 5e285562f783c806c764b11fcc48d638843c0f64
Author: loyso <loyso@chromium.org>
Date: Fri Jan 06 05:00:53 2017

[Sheriff] Disable flaky fast/text/ellipsis-stroked.html

NOTRY=true
TBR=sashab@chromium.org

BUG= 663855 

Review-Url: https://codereview.chromium.org/2617883003
Cr-Commit-Position: refs/heads/master@{#441877}

[modify] https://crrev.com/5e285562f783c806c764b11fcc48d638843c0f64/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfd4f2991d4d86e79a275641746cca8679c23b40

commit bfd4f2991d4d86e79a275641746cca8679c23b40
Author: qyearsley <qyearsley@chromium.org>
Date: Sun Jan 29 00:03:22 2017

Add flaky expectation for fast/text/ellipsis-with-list-marker-in-*-flow.html.

TBR=robhogan
TBR_REASON=Updating expectations to make continuous builders green again
BUG= 663855 , 685851 

Review-Url: https://codereview.chromium.org/2659213002
Cr-Commit-Position: refs/heads/master@{#446928}

[modify] https://crrev.com/bfd4f2991d4d86e79a275641746cca8679c23b40/third_party/WebKit/LayoutTests/TestExpectations

Comment 11 by robhogan@chromium.org, Jan 31 2017

Cc: qyears...@chromium.org
 Issue 686478  has been merged into this issue.

Comment 12 by robhogan@chromium.org, Jan 31 2017 

I've tracked the problem down to the word shaping cache. eae@ is right that ellipsis-platform-font-change.html needs to run as one of the tests in order to throw the rest off. I don't understand the word shaping cache machinery at all, but the value of 'totalWidth' varies in a single test from run to run, suggesting the cache isn't get cleared properly between runs and that it is retaining the result from the web-font test and carrying it over to subsequent runs:

float CachingWordShaper::fillGlyphBuffer(
    const Font* font,
    const TextRun& run,
    HashSet<const SimpleFontData*>* fallbackFonts,
    GlyphBuffer* glyphBuffer,
    unsigned from,
    unsigned to) {
  ShapeResultBuffer buffer;
  float totalWidth = shapeResultsForRun(m_shapeCache, font, run, fallbackFonts, &buffer);
  printf("totalWidth: %g\n", totalWidth);

  return buffer.fillGlyphBuffer(glyphBuffer, run, from, to);
}

I guess there's something about the ellipsis as a 'word' that prevents the cache getting cleared? At the moment I can't even see where it's supposed to be cleared down.

eae@ - can you see?

Comment 13 by robhogan@chromium.org, Feb 1 2017

Cc: e...@chromium.org
eae/drott - is there anything obvious you can see in the handling of the word shaper cache above?

Comment 14 by kojii@chromium.org, Feb 4 2017

Cc: ksakamoto@chromium.org
Thank you robhogan for looking into this.

> 'totalWidth' varies in a single test from run to run

That's really weird, and I agree with your assessment that something is wrong in the shape cahce. Is it for when fillGlyphBuffer is called for ellipsis?

Thought this is  issue 682999 , but it was fixed on Jan 24 and the web font name 'DroidSansSubset' doesn't appear in any other tests, so we may have another issue there.

Comment 15 by robhogan@chromium.org, Feb 7 2017 

Turns out it's something completely different! :/

CL up at https://codereview.chromium.org/2686693002
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e892c6f828b8b5da963f5c184cbda5d7841dfc5b

commit e892c6f828b8b5da963f5c184cbda5d7841dfc5b
Author: robhogan <robhogan@gmail.com>
Date: Thu Feb 09 20:08:42 2017

Don't keep a static copy of a font's ellipsis character.

If the font changes we won't pick up the new ellipsis character.

BUG= 663855 

Review-Url: https://codereview.chromium.org/2686693002
Cr-Commit-Position: refs/heads/master@{#449383}

[modify] https://crrev.com/e892c6f828b8b5da963f5c184cbda5d7841dfc5b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e892c6f828b8b5da963f5c184cbda5d7841dfc5b/third_party/WebKit/LayoutTests/fast/text/ellipsis-stroked-expected.html
[modify] https://crrev.com/e892c6f828b8b5da963f5c184cbda5d7841dfc5b/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.png
[modify] https://crrev.com/e892c6f828b8b5da963f5c184cbda5d7841dfc5b/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/e892c6f828b8b5da963f5c184cbda5d7841dfc5b/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/e892c6f828b8b5da963f5c184cbda5d7841dfc5b/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-expected.png
[modify] https://crrev.com/e892c6f828b8b5da963f5c184cbda5d7841dfc5b/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/e892c6f828b8b5da963f5c184cbda5d7841dfc5b/third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.png
[modify] https://crrev.com/e892c6f828b8b5da963f5c184cbda5d7841dfc5b/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

Comment 17 by e...@chromium.org, Feb 9 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55c5d4c17976044c58621837e801e409345a6ac6

commit 55c5d4c17976044c58621837e801e409345a6ac6
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Feb 09 21:46:21 2017

Auto-rebaseline for r449383

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/600237

https://chromium.googlesource.com/chromium/src/+/e892c6f828b8b

BUG= 663855 
TBR=robhogan@gmail.com

Review-Url: https://codereview.chromium.org/2684193004 .
Cr-Commit-Position: refs/heads/master@{#449424}

[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/bfb00e35e0d1cff74c3b402029fb5310c95bed7c/third_party/WebKit/LayoutTests/platform/android/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.png
[delete] https://crrev.com/bfb00e35e0d1cff74c3b402029fb5310c95bed7c/third_party/WebKit/LayoutTests/platform/android/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-rtl-text-in-rtl-flow-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-rtl-text-in-rtl-flow-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-rtl-text-in-rtl-flow-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/mac/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-rtl-text-in-rtl-flow-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.png
[modify] https://crrev.com/55c5d4c17976044c58621837e801e409345a6ac6/third_party/WebKit/LayoutTests/platform/win/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-expected.png

Comment 19 by robhogan@chromium.org, Feb 18 2017

Cc: liyuqian@google.com haraken@chromium.org dmazz...@chromium.org
 Issue 659123  has been merged into this issue.
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0d8d6ac72c8c8e0bf7447abe2ba455caf12d8cf

commit f0d8d6ac72c8c8e0bf7447abe2ba455caf12d8cf
Author: robhogan <robhogan@gmail.com>
Date: Sat Feb 18 19:08:58 2017

Unskip more tests that are no longer flaky

Follow up to https://codereview.chromium.org/2686693002, these tests should
no longer be flaky.

TBR=eae@chromium.org

BUG= 663855 

Review-Url: https://codereview.chromium.org/2704023002
Cr-Commit-Position: refs/heads/master@{#451486}

[modify] https://crrev.com/f0d8d6ac72c8c8e0bf7447abe2ba455caf12d8cf/third_party/WebKit/LayoutTests/TestExpectations
►

Sign in to add a comment