fast/filesystem/cross-filesystem-op.html is flaky when run in random order |
||||
Issue descriptionThe test: fast/filesystem/cross-filesystem-op.html appears to be flaky when run in random order. Steps to reproduce: This should pass consistently: Tools/Scripts/run-webkit-tests fast/filesystem/ This should fail intermittently: Tools/Scripts/run-webkit-tests fast/filesystem/ --order=random We're working on removing order dependency from Blink layout tests. More context here: https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit
,
Nov 14 2016
,
Nov 29 2016
From: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac_-_RandomOrder/29/layout-test-results/fast/filesystem/cross-filesystem-op-pretty-diff.html Failure is: ERROR:dest: createDirectory(/test): TypeMismatchError So yeah, hypothesis seems correct. Tools/Scripts/run-webkit-tests --child-processes=1 --order=random --seed=1480444199 fast/filesystem/cross-filesystem-op.html fast/filesystem/null-arguments.html
,
Nov 29 2016
,
Nov 29 2016
Several of the tests leave behind cruft like '/test' files. I don't want to muck with the tests too much but I'll make some additional fixes where easy.
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5 commit 7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5 Author: jsbell <jsbell@chromium.org> Date: Wed Nov 30 02:05:47 2016 Make fast/filesystem/cross-filesystem-op.html insensitive to test order Test assumed that '/test' could be created as a directory, which would fail if a previous test left '/test' behind as a file (as some do). Make the test clear out the root first, as many other tests do. Also tweak a few other tests to clean up when done, but not all tests were inspected/updated. R=jeffcarp@chromium.org BUG= 663852 Review-Url: https://codereview.chromium.org/2537193003 Cr-Commit-Position: refs/heads/master@{#435125} [modify] https://crrev.com/7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5/third_party/WebKit/LayoutTests/RandomOrderExpectations [modify] https://crrev.com/7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5/third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html [modify] https://crrev.com/7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5/third_party/WebKit/LayoutTests/fast/filesystem/not-enough-arguments.html [modify] https://crrev.com/7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5/third_party/WebKit/LayoutTests/fast/filesystem/null-arguments.html [modify] https://crrev.com/7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5/third_party/WebKit/LayoutTests/fast/filesystem/resources/null-arguments-worker.js
,
Nov 30 2016
Looking good on the bots so far. |
||||
►
Sign in to add a comment |
||||
Comment 1 by jsb...@chromium.org
, Nov 9 2016