Remove fast/events/onload-re-entry.html from TestExpectations |
||||||||
Issue descriptionThe tests: fast/events/onload-re-entry.html appears to be flaky when run in random order. Steps to reproduce: This should pass consistently: Tools/Scripts/run-webkit-tests fast/events/ This should fail intermittently: Tools/Scripts/run-webkit-tests fast/events/ --order=random We're working on removing order dependency from Blink layout tests. More context here: https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit
,
Nov 14 2016
,
Dec 8 2016
PTAL. If we can fix this my Dec 14 we avoid headaches with TestExpectations per Jeff's email to blink-dev.
,
Jan 24 2017
I couldn't reproduce this locally, and the dashboard doesn't record any failures though we switched to random-order. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=fast%2Fevents%2Fonload-re-entry.html
,
Jan 24 2017
jeffcarp@, do you have a test order list which reproduces the issue?
,
Jan 27 2017
I'm sorry, I don't have the data on that. I can try removing this test from TestExpectations and watch the builds to see if there's a failure. If it isn't flaky, then we can close this bug, and if it is, we'll have a good example of failure conditions.
,
Feb 3 2017
Thank you for providing more feedback. Adding requester "tkent@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 5 2017
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b034403ab50b3a27bda35d6cf72efec57f2f1217 commit b034403ab50b3a27bda35d6cf72efec57f2f1217 Author: qyearsley <qyearsley@chromium.org> Date: Tue Feb 07 17:50:47 2017 Remove flaky expectations with update-test-expectations script The update-test-expectations script is meant to remove flaky expectations when it appears that according to the most recent results on the flakiness dashboard for that test, the test is no longer flaky. BUG= 491764 , 498539 , 575766 , 600248 ,658305, 663838 , 663840 ,663848, 663851 , 663853 , 663872 , 663874 , 663877 , 663879 ,664817,664839, 664840 , 664841 , 664842 , 664846 , 664850 , 664855 , 664856 , 666991 , 671480 , 671618 , 672204 , 673296 , 673632 , 674720 ,674858, 678488 , 683800 Review-Url: https://codereview.chromium.org/2679543005 Cr-Commit-Position: refs/heads/master@{#448663} [modify] https://crrev.com/b034403ab50b3a27bda35d6cf72efec57f2f1217/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 7 2017
According to the flakiness dashboard, this test apparently doesn't appear to be flaky anymore, so the expectation was removed. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tkent@chromium.org
, Nov 11 2016Labels: Test-Layout
Status: Available (was: Untriaged)