iOS has Physical Web omnibox support coming. It'd be nice to have this on Android too.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb10309884380d1b09d90e47ab854355453d1558 commit eb10309884380d1b09d90e47ab854355453d1558 Author: cco3 <cco3@chromium.org> Date: Fri Dec 02 19:27:14 2016 Move Physical Web diagnostics page to new home This commit moves the Physical Web diagnostics page from chrome://physical-web to chrome://physical-web-diagnostics On iOS, chrome://physical-web points to a WebUI that lists Physical Web URLs. If we are to have some degree of parity in Android, the current diagnostics page needs to move to a different location. BUG= 663842 Review-Url: https://codereview.chromium.org/2547523003 Cr-Commit-Position: refs/heads/master@{#435992} [modify] https://crrev.com/eb10309884380d1b09d90e47ab854355453d1558/chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java [modify] https://crrev.com/eb10309884380d1b09d90e47ab854355453d1558/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java [modify] https://crrev.com/eb10309884380d1b09d90e47ab854355453d1558/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java [modify] https://crrev.com/eb10309884380d1b09d90e47ab854355453d1558/chrome/browser/android/ntp/new_tab_page_url_handler.cc [modify] https://crrev.com/eb10309884380d1b09d90e47ab854355453d1558/chrome/common/url_constants.cc [modify] https://crrev.com/eb10309884380d1b09d90e47ab854355453d1558/chrome/common/url_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c07a45d17ce723ac166020b5c108448baf765035 commit c07a45d17ce723ac166020b5c108448baf765035 Author: cco3 <cco3@chromium.org> Date: Thu Dec 29 21:52:22 2016 Move PW message handler logic to components We need a Physical Web WebUI on both iOS and Android. In order to support both and share code, we need to place all core message handler logic in components. BUG= 663842 Review-Url: https://codereview.chromium.org/2571853003 Cr-Commit-Position: refs/heads/master@{#440989} [modify] https://crrev.com/c07a45d17ce723ac166020b5c108448baf765035/components/physical_web/webui/BUILD.gn [add] https://crrev.com/c07a45d17ce723ac166020b5c108448baf765035/components/physical_web/webui/physical_web_base_message_handler.cc [add] https://crrev.com/c07a45d17ce723ac166020b5c108448baf765035/components/physical_web/webui/physical_web_base_message_handler.h [modify] https://crrev.com/c07a45d17ce723ac166020b5c108448baf765035/ios/chrome/browser/ui/webui/physical_web_ui.cc
Feature description for Physical Web omnibox suggestions in Chrome for Android: https://docs.google.com/presentation/d/11s8WTAbrIeAh1r_NiT4MTt_CKzdkxitaP2DseI8vQWQ/edit#slide=id.p
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6de2a4029db400e3581fe6595aeb9c7f1960f22d commit 6de2a4029db400e3581fe6595aeb9c7f1960f22d Author: cco3 <cco3@chromium.org> Date: Fri Jan 06 01:37:13 2017 Add a Physical Web WebUI for Android There is currently an Activity to display Physical Web URLs, but we'd like do display those URLs from a WebUI. In part, this will be simpler for redirecting from the omnibox. In part, it is simpler because we no longer need an Activity and will be able to move away from it. That is, we originally need to display Physical Web URLs without the native library loaded; this is no longer the case. BUG= 663842 Review-Url: https://codereview.chromium.org/2603043002 Cr-Commit-Position: refs/heads/master@{#441796} [modify] https://crrev.com/6de2a4029db400e3581fe6595aeb9c7f1960f22d/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/6de2a4029db400e3581fe6595aeb9c7f1960f22d/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [add] https://crrev.com/6de2a4029db400e3581fe6595aeb9c7f1960f22d/chrome/browser/ui/webui/physical_web/physical_web_ui.cc [add] https://crrev.com/6de2a4029db400e3581fe6595aeb9c7f1960f22d/chrome/browser/ui/webui/physical_web/physical_web_ui.h [modify] https://crrev.com/6de2a4029db400e3581fe6595aeb9c7f1960f22d/chrome/common/url_constants.cc [modify] https://crrev.com/6de2a4029db400e3581fe6595aeb9c7f1960f22d/chrome/common/url_constants.h [modify] https://crrev.com/6de2a4029db400e3581fe6595aeb9c7f1960f22d/components/physical_web/webui/physical_web_base_message_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cec11b6fe6c552ebe75b2b67f4eb20aab167621b commit cec11b6fe6c552ebe75b2b67f4eb20aab167621b Author: cco3 <cco3@chromium.org> Date: Fri Jan 06 20:15:22 2017 Add Physical Web omnibox support for Android This adds some degree of feature parity with iOS, which also has a Physical Web omnibox completion and zero-suggest feature. BUG= 663842 Review-Url: https://codereview.chromium.org/2604243002 Cr-Commit-Position: refs/heads/master@{#442024} [modify] https://crrev.com/cec11b6fe6c552ebe75b2b67f4eb20aab167621b/chrome/browser/android/omnibox/autocomplete_controller_android.cc [modify] https://crrev.com/cec11b6fe6c552ebe75b2b67f4eb20aab167621b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc [modify] https://crrev.com/cec11b6fe6c552ebe75b2b67f4eb20aab167621b/components/omnibox/browser/autocomplete_classifier.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d0bae6b0cf3d23a1b4d6a56e34ed015cfa82989 commit 5d0bae6b0cf3d23a1b4d6a56e34ed015cfa82989 Author: cco3 <cco3@chromium.org> Date: Thu Jan 12 02:53:01 2017 Auto-enable Physical Web for appropriate users Now that the Physical Web no longer displays notifications, the opt-in notification will not fire. Instead, users can enable the Physical Web manually, or if they have Google search enabled (i.e., they are already sending info to Google for omnibox results). Note that this is the same behavior as on iOS. BUG= 663842 Review-Url: https://codereview.chromium.org/2618613007 Cr-Commit-Position: refs/heads/master@{#443128} [modify] https://crrev.com/5d0bae6b0cf3d23a1b4d6a56e34ed015cfa82989/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5c9bcd8091d35691e61a939eb2aa8201baf57c8 commit b5c9bcd8091d35691e61a939eb2aa8201baf57c8 Author: cco3 <cco3@chromium.org> Date: Thu Jan 12 22:53:40 2017 Send users to Physical WebUI instead of Activity We have written a Physical Web WebUI that we intend to be the de facto view for browsing Physical Web URLs. This change makes sure the user goes there when they try to display URLs from: * the diagnostics page and * the settings fragment. BUG= 663842 Review-Url: https://codereview.chromium.org/2601273003 Cr-Commit-Position: refs/heads/master@{#443393} [modify] https://crrev.com/b5c9bcd8091d35691e61a939eb2aa8201baf57c8/chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java [modify] https://crrev.com/b5c9bcd8091d35691e61a939eb2aa8201baf57c8/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java [modify] https://crrev.com/b5c9bcd8091d35691e61a939eb2aa8201baf57c8/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java [modify] https://crrev.com/b5c9bcd8091d35691e61a939eb2aa8201baf57c8/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0df20a42550425c0edc2ca31e76ea5fe1efff67c commit 0df20a42550425c0edc2ca31e76ea5fe1efff67c Author: cco3 <cco3@chromium.org> Date: Tue Jan 17 21:54:22 2017 Consolidate PhysicalWeb list launch code Currently, only the Intent creation code is consolidated to launch an activity to list Physical Web URLs. This change also consolidates the actual call to launch the trusted intent. BUG= 663842 Review-Url: https://codereview.chromium.org/2636243003 Cr-Commit-Position: refs/heads/master@{#444157} [modify] https://crrev.com/0df20a42550425c0edc2ca31e76ea5fe1efff67c/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java [modify] https://crrev.com/0df20a42550425c0edc2ca31e76ea5fe1efff67c/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java [modify] https://crrev.com/0df20a42550425c0edc2ca31e76ea5fe1efff67c/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12a49ca76a658d24d34f6dbe9b6976adf65537a9 commit 12a49ca76a658d24d34f6dbe9b6976adf65537a9 Author: cco3 <cco3@chromium.org> Date: Tue Jan 17 23:17:44 2017 Add FLAG_ACTIVITY_NEW_TASK to trusted Intents Because we are starting trusted intents from the application context, we need FLAG_ACTIVITY_NEW_TASK on pre-N versions of Android. On N+ we can get away with specifying a task ID or not specifying an options bundle. This fixes a crash with the Physical Web that is currently failing to set this flag in its Intent. BUG= 663842 ,681441 Review-Url: https://codereview.chromium.org/2638153002 Cr-Commit-Position: refs/heads/master@{#444180} [modify] https://crrev.com/12a49ca76a658d24d34f6dbe9b6976adf65537a9/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java [modify] https://crrev.com/12a49ca76a658d24d34f6dbe9b6976adf65537a9/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9c42e9c5a72a3ac28d698e848fba2888a32e00f commit c9c42e9c5a72a3ac28d698e848fba2888a32e00f Author: cco3 <cco3@chromium.org> Date: Thu Jan 26 21:55:14 2017 Remove refine icon from multi-PW suggestions Currently, when a user is given a Physical Web overflow suggestion in the omnibox, a refine icon is also displayed. Tapping the refine icon will fill the omnibox with several titles rather than a URL. This change removes the refine icon in that condition. BUG= 663842 Review-Url: https://codereview.chromium.org/2653753009 Cr-Commit-Position: refs/heads/master@{#446463} [modify] https://crrev.com/c9c42e9c5a72a3ac28d698e848fba2888a32e00f/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3c9b8734cb9d06d1b9525769ede1ec2287c5ea1 commit e3c9b8734cb9d06d1b9525769ede1ec2287c5ea1 Author: Ted Choc <tedchoc@google.com> Date: Mon Jan 30 21:05:34 2017 Remove refine icon from multi-PW suggestions Currently, when a user is given a Physical Web overflow suggestion in the omnibox, a refine icon is also displayed. Tapping the refine icon will fill the omnibox with several titles rather than a URL. This change removes the refine icon in that condition. BUG= 663842 Review-Url: https://codereview.chromium.org/2653753009 Cr-Commit-Position: refs/heads/master@{#446463} (cherry picked from commit c9c42e9c5a72a3ac28d698e848fba2888a32e00f) Review-Url: https://codereview.chromium.org/2659353003 . Cr-Commit-Position: refs/branch-heads/2987@{#185} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/e3c9b8734cb9d06d1b9525769ede1ec2287c5ea1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
Comment 1 by bugdroid1@chromium.org
, Dec 2 2016