9 tests in fast/events/click-*.html are flaky when run in random order |
||||||||
Issue descriptionThe tests: fast/events/click-anchor-blur-refocus-window.html fast/events/click-anchor-refocus-window.html fast/events/click-checkbox-refocus-window.html fast/events/click-focus-anchor-has-ring.html fast/events/click-focus-keydown-no-ring.html fast/events/click-focus-svganchor-has-ring.html fast/events/click-focus-svganchor-no-ring.html fast/events/click-svganchor-blur-refocus-window.html fast/events/click-svganchor-refocus-window.html appear to be flaky when run in random order. Steps to reproduce: This should pass consistently: Tools/Scripts/run-webkit-tests fast/events/ This should fail intermittently: Tools/Scripts/run-webkit-tests fast/events/ --order=random We're working on removing order dependency from Blink layout tests. More context here: https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit Also let me know if this chunk of tests is too big and I can split them into bugs with smaller chunks.
,
Nov 13 2016
,
Nov 13 2016
These tests are self-contained, but they depend on focus (and mouse position). When tests are run in parallel, are the element focus and mouse position independent? I guess not, and that would probably be the cause of the flakiness.
,
Nov 14 2016
,
Nov 18 2016
#c3, they are independent. However, it seems mouse position is not reset on navigating to the next test. It might explain the order dependency. See component/test_runner/event_sender.*
,
Nov 18 2016
#c5 The tests are independent too (relative to each other). I don't see how not resetting the mouse position would affect the test results, because the tests from the bug start with a call to eventSender.mouseMoveTo, which ought to explicitly set the mouse position at the expected location.
,
Nov 21 2016
,
Jan 6 2017
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b034403ab50b3a27bda35d6cf72efec57f2f1217 commit b034403ab50b3a27bda35d6cf72efec57f2f1217 Author: qyearsley <qyearsley@chromium.org> Date: Tue Feb 07 17:50:47 2017 Remove flaky expectations with update-test-expectations script The update-test-expectations script is meant to remove flaky expectations when it appears that according to the most recent results on the flakiness dashboard for that test, the test is no longer flaky. BUG= 491764 , 498539 , 575766 , 600248 ,658305, 663838 , 663840 ,663848, 663851 , 663853 , 663872 , 663874 , 663877 , 663879 ,664817,664839, 664840 , 664841 , 664842 , 664846 , 664850 , 664855 , 664856 , 666991 , 671480 , 671618 , 672204 , 673296 , 673632 , 674720 ,674858, 678488 , 683800 Review-Url: https://codereview.chromium.org/2679543005 Cr-Commit-Position: refs/heads/master@{#448663} [modify] https://crrev.com/b034403ab50b3a27bda35d6cf72efec57f2f1217/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 7 2017
The flaky expectations have now been removed because in recent runs on the continuous builders the tests don't appear to be flaky (according to the flakiness dashboard) - maybe this can be closed?
,
Feb 7 2017
Let's close the bug. I don't see a reason for them being flaky in the first place. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jeffcarp@chromium.org
, Nov 9 2016