New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663830 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 651282



Sign in to add a comment

Replace connection error column with notifications

Project Member Reported by mbrunson@chromium.org, Nov 9 2016

Issue description

The device table on chrome://bluetooth-internals uses a specific column to show errors when connecting to a device. A snackbar may be better for these types of errors.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22fa9c78d47051c4da59d68e38b2e6bd9b76f880

commit 22fa9c78d47051c4da59d68e38b2e6bd9b76f880
Author: mbrunson <mbrunson@chromium.org>
Date: Wed Dec 21 01:22:29 2016

bluetooth: Add notification system to internals page.

Adds notification system to internals page using a snackbar UI element.

The snackbar system can be invoked from any page using Snackbar.show and
Snackbar.dismiss and come in a variety of styles (info, success, warning, and
danger) depending on the need of the caller. Multiple snackbar requests can be
queued and are shown one at a time.

Removes connection error column from DeviceTable.

Error and success messages are now shown in a snackbar displayed from
bluetooth_internals.js.

Screenshots: https://goo.gl/photos/p7fb2QH3e7UpcZA47
GIFs: https://goo.gl/photos/9PWexXFZ6prr4uVq5

BUG= 663830 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2568283003
Cr-Commit-Position: refs/heads/master@{#439963}

[modify] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/browser/browser_resources.grd
[modify] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/browser/resources/bluetooth_internals/device_collection.js
[modify] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/browser/resources/bluetooth_internals/device_table.js
[modify] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/browser/resources/bluetooth_internals/sidebar.js
[add] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/browser/resources/bluetooth_internals/snackbar.js
[modify] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/22fa9c78d47051c4da59d68e38b2e6bd9b76f880/chrome/test/data/webui/bluetooth_internals_browsertest.js

Status: Fixed (was: Assigned)

Sign in to add a comment