New issue
Advanced search Search tips

Issue 663818 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove AudioSourceNode class

Project Member Reported by rtoy@chromium.org, Nov 9 2016

Issue description

All of the source nodes in WebAudio derive from AudioSourceNode class.

This is ok, but the AudioSourceNode is also defined in WebIDL, making it visible in at least the prototypes of the source nodes.  This isn't part of the WebAudio spec, so it should be removed.

 

Comment 1 by rtoy@chromium.org, Jan 10 2017

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/717012126c57dfe596b6562f9ad17f2a7e537a5b

commit 717012126c57dfe596b6562f9ad17f2a7e537a5b
Author: rtoy <rtoy@chromium.org>
Date: Mon Jan 23 19:36:28 2017

Remove AudioSourceNode class

The MediaElementAudioSourceNode and MediaStreamAudioSourceNode were
implemented as deriving from an AudioSourceNode.  This is not part of
the spec; these nodes are derived from AudioNode.  This was only
visible in the prototype chain for these classes.  The AudioSourceNode
is otherwise invisible to the user; it is not constructible and has no
properties.

Thus, remove the AudioSourceNode class.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/D-QJm9GCisc/gSCZwIrfFgAJ

BUG= 663818 
TEST=none

Review-Url: https://codereview.chromium.org/2621923003
Cr-Commit-Position: refs/heads/master@{#445433}

[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/69b49a8ebcb7b1efddf89262b0ca36a300d756a5/third_party/WebKit/Source/modules/webaudio/AudioSourceNode.h
[delete] https://crrev.com/69b49a8ebcb7b1efddf89262b0ca36a300d756a5/third_party/WebKit/Source/modules/webaudio/AudioSourceNode.idl
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/Source/modules/webaudio/BUILD.gn
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.idl
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h
[modify] https://crrev.com/717012126c57dfe596b6562f9ad17f2a7e537a5b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.idl

Comment 3 by rtoy@chromium.org, Jan 24 2017

Status: Fixed (was: Started)

Sign in to add a comment