Issue 663809 link

Starred by 2 users

Issue metadata

Status:	Untriaged
Owner:	----
Cc:	mustash-bugs@google.com
Components:	Internals>Services>Ash Internals>Services>WindowService Tests>Disabled
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
Test-Disabled Proj-Mash-WS2

GetContext() isn't applicable to aura-mus client

Project Member Reported by sky@chromium.org, Nov 9 2016

Issue description

AuraTestHelper::GetContext() doesn't make sense for aura-mus-client. The reason GetContext() doesn't make sense is that GetContext() is created by AuraTestHelper from a WindowTreeHost and is generally used to correspond to the root of an ash environment where you use NativeWidgetAura. This only makes sense for the
aura-mus-windowmanager config.

This bug is for all tests disabled because of this. We need to go through all the tests disabled by this and decide if we need to convert to work with aura-mus-client (meaning not use GetContext()), or leave specific to aura-mus-windowmanager.

I'll also mention that these tests have almost exclusively created NativeWidgetAura (meaning if you run views_unittests they create NativeWidgetAura), which means they never exercised DesktopNativeWidgetAura in the past. So, it may be ok to continue not running these tests, but we need to evaluate them.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a178499ab5e3a157c30198dc94deed31104360d9

commit a178499ab5e3a157c30198dc94deed31104360d9
Author: sky <sky@chromium.org>
Date: Fri Nov 11 05:34:32 2016

Changes views_aura_mus_unittests to create DesktopNativeWidgetAura

And disables a bunch of tests that are either broke or don't make
sense.

Tests that don't call CreatePlatformNativeWidgetImpl() already
create a DesktopNativeWidgetAura, but those calling
CreatePlatformNativeWidgetImpl() ended up with a
NativeWidgetAura. This patch makes it so when aura-mus-client is used
CreatePlatformNativeWidgetImpl() creates a DesktopNativeWidgetAura
(assuming that is appropriate).

Additionally I'm making ViewsTestBase::GetContext() return null for
aura-mus-client. That way we sure see failures early on.

BUG= 663903  663809 663561  663868   664261   664280   615033 
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2488393003
Cr-Commit-Position: refs/heads/master@{#431505}

[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/BUILD.gn
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/accessible_pane_view_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/controls/button/menu_button_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/controls/native/native_view_host_aura_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/event_monitor_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/focus/focus_manager_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/mus/mus_client.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/mus/mus_client.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/mus/views_aura_mus_test_suite.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/mus/views_mus_test_suite.cc
[delete] https://crrev.com/93f33fbe1479699499e6e05793785a02fdb1cc81/ui/views/test/native_widget_factory.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/native_widget_factory.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/native_widget_factory_aura_mus.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/native_widget_factory_desktop.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/native_widget_factory_mus.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/platform_test_helper.h
[add] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/platform_test_helper_cocoa.mm
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/scoped_views_test_helper.h
[add] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/test_platform_native_widget.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/test_views.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/views_test_base.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/views_test_base.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/views_test_helper_aura.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/widget_test.h
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/widget_test_aura.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/test/widget_test_mac.mm
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/touchui/touch_selection_controller_impl_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/touchui/touch_selection_menu_runner_views_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/view_unittest_aura.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/native_widget_mac_unittest.mm
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/native_widget_unittest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/a178499ab5e3a157c30198dc94deed31104360d9/ui/views/widget/widget_unittest.cc