New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663807 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[chromecast] Move required command-line flags from filters to tests

Project Member Reported by alokp@chromium.org, Nov 9 2016

Issue description

We currently pass all required command-line flags using unittest filters, which is hard to find and makes it cumbersome for developers to run the tests locally. Ideally we should be able to just run the unittests without any flags. The flags should be specified by the tests themselves.

For browser tests, there is already a virtual function BrowserTestBase::SetUpCommandLine which can be overridden by individual tests to specify additional flags. We should move the flags in filters to tests.
 

Comment 1 by mbjorge@google.com, Nov 9 2016

Would the tests be able to specify flags such as --test-launcher-timeout=90000, --test-launcher-batch-limit=25, or --test-launcher-jobs=1?

We also pass some flags conditionally based on build type, e.g. 

      if (!is_cast_desktop_build) {
        args += [ "--use-gpu-in-tests" ]
      }

which would probably require creating many BUILDFLAGs

Do you know if we can also pass the gtest filters this way?

Comment 2 by mbjorge@google.com, Nov 9 2016

Not that we necessarily have to solve all of the uses of flags in Comment 1 the same way.

One advantage of the current system is that all the flags for a given test (foo_unittests) can be found in the foo_unittests_filter variable.

Also of note is that building the "cast_test_lists" target with ninja will generate the out_*/release/tests/run_test_list.txt file, which lists the full command line for every unittest. It might be worthwhile to create a lightweight version of this target that generates the list without needing to build all the unittest executables

Comment 3 by alokp@chromium.org, Nov 9 2016

-test-launcher-foo flags are not important for running locally, so they can be specified in filters. I believe chromium uses recipes for such flags?

Ideally we should not have to worry about using gpu or not. It should be transparent to the code/test by using whatever GL driver (mesa or real) is present. We can look at such flags on a case-by-cases basis and fix the code/test if necessary.

The problem with cast_test_lists is that:
1. Very few people know about it
2. Developers need to find the file; open it; copy-paste flags. This bug is about removing this hassle.
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 10 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)

Sign in to add a comment