System menu detailed views get resized to contents upon shelf layout |
|||||||||
Issue descriptionVersion: 56.0.2915.0 OS: Chrome OS What steps will reproduce the problem? (1) Open one of the system menu detailed pages (network or Bluetooth) (2) Make sure there are enough items to show a scrollbar (3) Force a work area change or shelf layout (e.g. notification popup or display host resize) What is the expected result? System menu does not change its size What happens instead? System menu is resized to its contents (may become taller or shorter) I could not repro this with 56.0.2905.0 (dev) on samus so this could be a recent regression.
,
Nov 9 2016
Sorry, I meant r430619.
,
Nov 10 2016
collateral damage
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcd3a8aae5f2f849b50b31d95ae7802eaf5db484 commit dcd3a8aae5f2f849b50b31d95ae7802eaf5db484 Author: estade <estade@chromium.org> Date: Thu Nov 10 03:15:40 2016 Fix sizing of tray details scroll views. I tried to make this code make more sense, but touching scroll views is always a bit like Jenga so in the end I went for the minimal change that fixes the observed bug. (The fragile code is something that we inherited from the pre-MD layout.) BUG= 663790 Review-Url: https://codereview.chromium.org/2491713003 Cr-Commit-Position: refs/heads/master@{#431161} [modify] https://crrev.com/dcd3a8aae5f2f849b50b31d95ae7802eaf5db484/ash/common/system/tray/tray_details_view.cc
,
Nov 10 2016
,
Nov 10 2016
Tried with ToT that I think includes the change (at r431289) and I can still see the detailed view snapping to a larger size when notification arrives (e.g. connecting a fake VPN) or when resizing desktop window host.
,
Nov 11 2016
seems my fix only worked for detailed views with enough items to create scrollbars...
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ebb32cb3aefbc61483a1dd1cb81561fef0323e4 commit 0ebb32cb3aefbc61483a1dd1cb81561fef0323e4 Author: estade <estade@chromium.org> Date: Fri Nov 11 22:22:48 2016 Try to fix layout of scroll views in TrayDetailsViews. This code is still going to be fairly fragile, but it does get rid of nearly all code in FixedSizedScrollView (for MD), which will hopefully make it easier to reason about layout or make changes. Note that this collaterally fixes a bug where we reserved 1dp at the bottom of the scroller such that elements at the bottom of the scroll area would be 1dp above the bottom of the bubble. The specs show them as full bleed, and this fixes that (plus it makes scroll view layout even simpler because ClipHeightTo doesn't take into account insets). BUG= 663790 Review-Url: https://codereview.chromium.org/2496873002 Cr-Commit-Position: refs/heads/master@{#431666} [modify] https://crrev.com/0ebb32cb3aefbc61483a1dd1cb81561fef0323e4/ash/common/system/tray/fixed_sized_scroll_view.cc [modify] https://crrev.com/0ebb32cb3aefbc61483a1dd1cb81561fef0323e4/ash/common/system/tray/tray_details_view.cc [modify] https://crrev.com/0ebb32cb3aefbc61483a1dd1cb81561fef0323e4/ash/common/system/tray/tray_details_view.h
,
Nov 14 2016
fingers crossed
,
Feb 10 2017
,
Feb 21 2017
,
May 10 2017
9534.0.0, 60.0.3092.0 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by moh...@chromium.org
, Nov 9 2016Owner: est...@chromium.org
Status: Assigned (was: Available)