Android Cronet L Builder / M 64bit Perf failing cronet_test_instrumentation_apk |
|||||
Issue description
,
Nov 9 2016
potentially due to https://codereview.chromium.org/2461683002 ?
,
Nov 9 2016
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/164c05075c0879d38c72ca75ea8719fb6e5181fd commit 164c05075c0879d38c72ca75ea8719fb6e5181fd Author: timvolodine <timvolodine@chromium.org> Date: Wed Nov 09 18:08:20 2016 [Android] Disable failing Quic tests on cronet bots. The QuicTest tests started failing on the cronet bots. (see crbug.com/663789 ) BUG= 663789 NOTRY=true TBR=mikecase@chromium.org,bnc@chromium.org,mef@chromium.org Review-Url: https://codereview.chromium.org/2489793003 Cr-Commit-Position: refs/heads/master@{#430976} [modify] https://crrev.com/164c05075c0879d38c72ca75ea8719fb6e5181fd/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
,
Nov 9 2016
Yes, it was indeed my change https://crrev.com/2461683002 that broke the tests. xunjieli fixed it at https://crrev.com/2484863010. In light of that, the tests can be re-enabled.
,
Nov 9 2016
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d2f734c5df7942278ea1e68ac1fa86877afd146 commit 8d2f734c5df7942278ea1e68ac1fa86877afd146 Author: bnc <bnc@chromium.org> Date: Wed Nov 09 22:15:57 2016 Reenable Cronet tests. Tests broke because of https://crrev.com/2461683002. Tests were fixed at https://crrev.com/2484863010. Independently, tests were disabled at https://crrev.com/2489793003. As tests were fixed, it is safe to re-enable them. BUG= 663789 Review-Url: https://codereview.chromium.org/2487333002 Cr-Commit-Position: refs/heads/master@{#431050} [modify] https://crrev.com/8d2f734c5df7942278ea1e68ac1fa86877afd146/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
,
Nov 10 2016
Builders mentioned in opening post seem to be happy for the last three builds, so I'm closing this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by timvolod...@chromium.org
, Nov 9 2016