New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 663789 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android Cronet L Builder / M 64bit Perf failing cronet_test_instrumentation_apk

Project Member Reported by timvolod...@chromium.org, Nov 9 2016

Issue description

from https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder/builds/3808/steps/cronet_test_instrumentation_apk/logs/stdio

C  127.241s Main  Detailed Logs
C  127.241s Main  ********************************************************************************
C  127.242s Main  [FAIL] org.chromium.net.QuicTest#testMetricsWithQuic:
C  127.242s Main  java.lang.Throwable: CronetTestBase#runTest failed.
C  127.242s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:146)
C  127.242s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  127.242s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  127.242s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  127.242s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
C  127.242s Main  Caused by: junit.framework.ComparisonFailure: expected:<[quic/1+spdy/3]> but was:<[http/2+quic/35]>
C  127.242s Main  	at org.chromium.net.QuicTest.testMetricsWithQuic(QuicTest.java:232)
C  127.242s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:130)
C  127.242s Main  	... 9 more
C  127.242s Main  
C  127.242s Main  [FAIL] org.chromium.net.QuicTest#testQuicLoadUrl:
C  127.243s Main  java.lang.Throwable: CronetTestBase#runTest failed.
C  127.243s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:146)
C  127.243s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  127.243s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  127.243s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  127.243s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
C  127.243s Main  Caused by: junit.framework.ComparisonFailure: expected:<[quic/1+spdy/3]> but was:<[http/2+quic/35]>
C  127.243s Main  	at org.chromium.net.QuicTest.testQuicLoadUrl(QuicTest.java:94)
C  127.243s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:130)
C  127.243s Main  	... 9 more
C  127.243s Main  
C  127.243s Main  [FAIL] org.chromium.net.QuicTest#testRealTimeNetworkQualityObservationsWithQuic:
C  127.243s Main  java.lang.Throwable: CronetTestBase#runTest failed.
C  127.243s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:146)
C  127.243s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  127.243s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  127.244s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C  127.244s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
C  127.244s Main  Caused by: junit.framework.ComparisonFailure: expected:<[quic/1+spdy/3]> but was:<[http/2+quic/35]>
C  127.244s Main  	at org.chromium.net.QuicTest.testRealTimeNetworkQualityObservationsWithQuic(QuicTest.java:188)
C  127.244s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:130)
C  127.244s Main  	... 9 more
C  127.244s Main  ********************************************************************************
C  127.244s Main  Summary
C  127.244s Main  ********************************************************************************
C  127.245s Main  [==========] 296 tests ran.
C  127.246s Main  [  PASSED  ] 293 tests.
C  127.246s Main  [  FAILED  ] 3 tests, listed below:
C  127.246s Main  [  FAILED  ] org.chromium.net.QuicTest#testMetricsWithQuic
C  127.246s Main  [  FAILED  ] org.chromium.net.QuicTest#testQuicLoadUrl
C  127.246s Main  [  FAILED  ] org.chromium.net.QuicTest#testRealTimeNetworkQualityObservationsWithQuic
C  127.246s Main  
C  127.246s Main  3 FAILED TESTS
potentially due to https://codereview.chromium.org/2461683002 ?
Cc: mikec...@chromium.org
Owner: b...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/164c05075c0879d38c72ca75ea8719fb6e5181fd

commit 164c05075c0879d38c72ca75ea8719fb6e5181fd
Author: timvolodine <timvolodine@chromium.org>
Date: Wed Nov 09 18:08:20 2016

[Android] Disable failing Quic tests on cronet bots.

The QuicTest tests started failing on the cronet bots.
(see  crbug.com/663789 )

BUG= 663789 
NOTRY=true
TBR=mikecase@chromium.org,bnc@chromium.org,mef@chromium.org

Review-Url: https://codereview.chromium.org/2489793003
Cr-Commit-Position: refs/heads/master@{#430976}

[modify] https://crrev.com/164c05075c0879d38c72ca75ea8719fb6e5181fd/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Comment 5 by b...@chromium.org, Nov 9 2016

Status: Started (was: Untriaged)
Yes, it was indeed my change https://crrev.com/2461683002 that broke the tests.  xunjieli fixed it at https://crrev.com/2484863010.  In light of that, the tests can be re-enabled.

Comment 6 by b...@chromium.org, Nov 9 2016

Cc: xunji...@chromium.org
The tests are fixed in r430968. The disable CL went in r430976. timvolodine@ do you mind reverting your CL? That might be the fastest way.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d2f734c5df7942278ea1e68ac1fa86877afd146

commit 8d2f734c5df7942278ea1e68ac1fa86877afd146
Author: bnc <bnc@chromium.org>
Date: Wed Nov 09 22:15:57 2016

Reenable Cronet tests.

Tests broke because of https://crrev.com/2461683002.
Tests were fixed at https://crrev.com/2484863010.
Independently, tests were disabled at https://crrev.com/2489793003.
As tests were fixed, it is safe to re-enable them.

BUG= 663789 

Review-Url: https://codereview.chromium.org/2487333002
Cr-Commit-Position: refs/heads/master@{#431050}

[modify] https://crrev.com/8d2f734c5df7942278ea1e68ac1fa86877afd146/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Comment 9 by b...@chromium.org, Nov 10 2016

Status: Fixed (was: Started)
Builders mentioned in opening post seem to be happy for the last three builds, so I'm closing this issue.

Sign in to add a comment