Commit Queue +1/+2 are too misleading |
||||||||||
Issue descriptionAffected Version: 2.13.2-1243-g3595e46 What steps will reproduce the problem? 1. Open https://skia-review.googlesource.com/c/4535/ What is the expected output? Some more obvious way to signal the difference between dry runs and the commit. What do you see instead? Commit Queue +1 / Commit Queue +2; Issues: 1) There are 15 characters in "Commit Queue +X", but dry run and commit differ only by 1 - the last one. Moreover, keys for "1" and "2" are adjacent on the keyboard. 2) I do not understand the math: dry run + 1 = commit; 3) I do not like similarity to Code Review +1, while there is no connection at all. Moreover, now I cannot scim through such text, because both start with "C" and end with "+1"; 4) It is non intuitive at all, I am sure that without hovering on it no one will get what "Commit Queue +1" vs "Commit Queue +2" means, am I wrong?
,
Nov 9 2016
,
Nov 9 2016
,
Nov 9 2016
That's a fair issue and one I thought for a while. I think the only short term solution is papering +1/+2 over in UI using CQ plugin. ON CLI interface, git cl already hides these +1/+2. Long term, we should really re-think Gerrit <-> CQ integration to provide more critique-like features such as auto-submit on LGTM and the like. But this is way beyond this specific issue.
,
Nov 16 2016
Moving this into Milestone-Launch, as less confusing labels may be a blocker for full launch, but we won't know that for sure until we have chromium subteams/subdirectories dogfooding.
,
Jan 13 2017
We're not going to do this as part of the Gerrit migration. In particular, making one of the labels string-valued instead of integer-valued would be more confusing, especially while the other labels remain integer-valued. A lot of things have been done to make them less confusing: * When mousing over a label, the human-readable text is displayed * When labels are shown in emails, the human-readable text is sent We can reconsider this either as part of a larger overhaul of gerrit labels (such that they're all primarily string-valued) or as part of an overhaul of CQ (so that we don't use labels for CQ at all, and instead hit an API endpoint or something). Moving to the CQ portion of the tracker.
,
Jan 23 2017
,
May 1 2017
,
May 26 2017
I am still confused by this. 1) The button for dry run uses a string, but shows as an integer label, so I mistakenly lgtm my own CLs instead of Dry Run. 2) I cannot find out whether it is LGTM or Dry Run just by looking at the label (I need to check the left column first). Probably, this does not bother others, so I will try something out with locally overriding the label text :)
,
May 30 2017
We're working on an incremental improvement, to make it more obvious what your votes are without hiding the integers, here: https://bugs.chromium.org/p/gerrit/issues/detail?id=6306
,
Aug 31 2017
,
Aug 31 2017
,
Jan 3 2018
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
,
Jan 4 2018
The "Dry Run" and "Submit to CQ" buttons in the upper right resolve this issue. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by andyb...@chromium.org
, Nov 9 2016