New issue
Advanced search Search tips

Issue 663781 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

views tooltiptests don't work with aura-mus client config

Project Member Reported by sky@chromium.org, Nov 9 2016

Issue description

These use GetContext(). GetContext() is really only valid for the window manager side of aura-mus and should go away. We need to evaluate these tests and either reimplement for aura-mus client, or decide it doesn't make sense and we have coverage else where.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce4cfbd771f398405d2985095f9d4774aa0a04f6

commit ce4cfbd771f398405d2985095f9d4774aa0a04f6
Author: sky <sky@chromium.org>
Date: Wed Nov 09 18:24:52 2016

Disables tooltip tests for aura-mus-client

These tests use AuraTestHelper::GetContext(), which doesn't make sense for
aura-mus-client. The reason GetContext() doesn't make sense is that
GetContext() is created by AuraTestHelper from a WindowTreeHost and is
generally used to corresponds to the root of an ash environment where
you use NativeWidgetAura. This only makes sense for the
aura-mus-windowmanager config.

So, I'm making these early out for now and we'll have to reevaluate
them later.

BUG=663781
TEST=test only change
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2489903002
Cr-Commit-Position: refs/heads/master@{#430982}

[modify] https://crrev.com/ce4cfbd771f398405d2985095f9d4774aa0a04f6/ui/views/corewm/tooltip_controller_unittest.cc
[modify] https://crrev.com/ce4cfbd771f398405d2985095f9d4774aa0a04f6/ui/views/mus/views_aura_mus_test_suite.cc
[modify] https://crrev.com/ce4cfbd771f398405d2985095f9d4774aa0a04f6/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/ce4cfbd771f398405d2985095f9d4774aa0a04f6/ui/views/test/platform_test_helper.h
[modify] https://crrev.com/ce4cfbd771f398405d2985095f9d4774aa0a04f6/ui/views/test/views_test_base.cc
[modify] https://crrev.com/ce4cfbd771f398405d2985095f9d4774aa0a04f6/ui/views/test/views_test_base.h

Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Sign in to add a comment