New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 663780 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
b...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Cronet QuicTest failures

Project Member Reported by xunji...@chromium.org, Nov 9 2016 
C  125.708s Main  Caused by: junit.framework.ComparisonFailure: expected:<[quic/1+spdy/3]> but was:<[http/2+quic/35]>
C  125.709s Main  	at org.chromium.net.QuicTest.testRealTimeNetworkQualityObservationsWithQuic(QuicTest.java:188)
C  125.709s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  125.709s Main  	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:130)

https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29/builds/3521/steps/cronet_test_instrumentation_apk/logs/stdio

+bnc, Bence looks like we need to update QuicTest expectations?

Comment 1 by xunji...@chromium.org, Nov 9 2016 

This is regarding https://codereview.chromium.org/2461683002

Comment 2 by xunji...@chromium.org, Nov 9 2016

Cc: b...@chromium.org
Owner: xunji...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afd11b9a1533fd51f690f544bfa879e9a4e15f93

commit afd11b9a1533fd51f690f544bfa879e9a4e15f93
Author: xunjieli <xunjieli@chromium.org>
Date: Wed Nov 09 17:52:41 2016

Fix QuicTest.java assertion on protocol string

QUIC protocol string has changed in https://codereview.chromium.org/2461683002.
This CL updates expectations.

R=kapishnikov@chromium.org

BUG= 663780 

Review-Url: https://codereview.chromium.org/2484863010
Cr-Commit-Position: refs/heads/master@{#430968}

[modify] https://crrev.com/afd11b9a1533fd51f690f544bfa879e9a4e15f93/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Comment 5 by xunji...@chromium.org, Nov 9 2016

Status: Fixed (was: Started)

Comment 6 by b...@chromium.org, Nov 9 2016 

Thank you for fixing this.
►

Sign in to add a comment