New issue
Advanced search Search tips

Issue 663773 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 614955



Sign in to add a comment

W3C importer: Remove test_converter and stop modifying tests when importing.

Project Member Reported by qyears...@chromium.org, Nov 9 2016

Issue description

Now, there are just a few differences between the tests with conversion and without:

https://codereview.chromium.org/2485493002

In csswg-test:

(a) Path to support file from reference html file is different for reference tests in csswg-test/css-shapes-1/shape-outside/supported-shapes. So we probably still want the behavior of convert_reference_relpaths in _W3CTestConverter. What we really want to do here is to change the layout test runner to understand <link rel=match href="...">, and then the paths in reference files don't need to be changed.

(b) Conversion adds "-webkit-" prefix to text-emphasis CSS property; this does change behavior, since the unprefixed version "text-emphasis" is only supported by Firefox (-webkit-text-emphasis is supported in Chrome, Opera, Safari).

(c) Conversion mangles "support/tcu-font.woff" into "suppotcu-font.woff". The behavior without conversion is correct, and the test could be failing for us just because of the change when the test is imported.
 

Comment 1 by foolip@chromium.org, Nov 17 2016

Blockedon: 666433

Comment 2 by tkent@chromium.org, Nov 17 2016

Blockedon: 614955

Comment 3 by tkent@chromium.org, Nov 17 2016

Blockedon: -666433
Owner: qyears...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment