W3C importer: Remove test_converter and stop modifying tests when importing. |
||||
Issue descriptionNow, there are just a few differences between the tests with conversion and without: https://codereview.chromium.org/2485493002 In csswg-test: (a) Path to support file from reference html file is different for reference tests in csswg-test/css-shapes-1/shape-outside/supported-shapes. So we probably still want the behavior of convert_reference_relpaths in _W3CTestConverter. What we really want to do here is to change the layout test runner to understand <link rel=match href="...">, and then the paths in reference files don't need to be changed. (b) Conversion adds "-webkit-" prefix to text-emphasis CSS property; this does change behavior, since the unprefixed version "text-emphasis" is only supported by Firefox (-webkit-text-emphasis is supported in Chrome, Opera, Safari). (c) Conversion mangles "support/tcu-font.woff" into "suppotcu-font.woff". The behavior without conversion is correct, and the test could be failing for us just because of the change when the test is imported.
,
Nov 17 2016
,
Nov 17 2016
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a98813b529a60bebc96f001559804652630be7c3 commit a98813b529a60bebc96f001559804652630be7c3 Author: qyearsley <qyearsley@chromium.org> Date: Fri Mar 31 01:09:47 2017 Stop trying to convert CSS properties in imported tests. BUG= 614955 , 663773 Review-Url: https://codereview.chromium.org/2790723002 Cr-Commit-Position: refs/heads/master@{#460970} [delete] https://crrev.com/76554ae5a13a9e78a12c4782287319820d270c15/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py [delete] https://crrev.com/76554ae5a13a9e78a12c4782287319820d270c15/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py [modify] https://crrev.com/a98813b529a60bebc96f001559804652630be7c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py [modify] https://crrev.com/a98813b529a60bebc96f001559804652630be7c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier_unittest.py
,
Mar 31 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by foolip@chromium.org
, Nov 17 2016